[CDRIVER-510] Fix for GridFS file seek if page == NULL Created: 23/Jan/15  Updated: 23/Oct/15  Resolved: 17/Sep/15

Status: Closed
Project: C Driver
Component/s: GridFS
Affects Version/s: None
Fix Version/s: 1.3.0-beta0

Type: Bug Priority: Major - P3
Reporter: Samantha Ritter (Inactive) Assignee: Kyle Suarez
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by CDRIVER-684 application crash Closed
is duplicated by CDRIVER-847 Cannot seek on new GridFS file Closed

 Description   

The latest gridfs fix doesn't cover case when page == NULL.

 
if (offset / file->chunk_size != file->pos / file->chunk_size) {
  ...
} else {
   _mongoc_gridfs_file_page_seek (file->page, offset % file->chunk_size);
}
 

If page == NULL, pos == 0 and offset < chunk_size it will try to seek in NULL page



 Comments   
Comment by Githook User [ 17/Sep/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}

Message: Merge pull request #269 from ksuarz/CDRIVER-510

CDRIVER-510 don't seek if page is NULL
Branch: 1.3.0-dev
https://github.com/mongodb/mongo-c-driver/commit/a6ec64172b77af41c77e79caa3c44e69f34b5591

Comment by Githook User [ 17/Sep/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}

Message: Merge pull request #269 from ksuarz/CDRIVER-510

CDRIVER-510 don't seek if page is NULL
Branch: 1.3.0-dev
https://github.com/mongodb/mongo-c-driver/commit/a6ec64172b77af41c77e79caa3c44e69f34b5591

Comment by Githook User [ 17/Sep/15 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'ksuarz@gmail.com'}

Message: CDRIVER-510 don't seek if page is NULL
Branch: 1.3.0-dev
https://github.com/mongodb/mongo-c-driver/commit/494c3dbb07ffec22f563c23bdf5d82e4e5913b9b

Comment by Kyle Suarez [ 16/Sep/15 ]

CDRIVER-847 comes down to the same check: seeking on a page that's NULL.

Comment by A. Jesse Jiryu Davis [ 05/Aug/15 ]

Thanks Alex. I'll write a test for this and make sure it's really fixed later this quarter.

Comment by Alex [ 27/Jul/15 ]

This is already fixed

Generated at Wed Feb 07 21:09:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.