[CDRIVER-528] Use maxWriteBatchSize from ismaster for write command batch splitting. Created: 12/Feb/15 Updated: 07/Jun/19 Resolved: 27/May/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Bulk API |
| Affects Version/s: | None |
| Fix Version/s: | 1.2-beta0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Hannes Magnusson | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Case: | (copied to CRM) | ||||||||||||||||||||||||||||
| Description |
|
MAX_INSERT_BATCH is hardcoded to 1000 rather then using node->max_write_batch_size which is read from isMaster. |
| Comments |
| Comment by Githook User [ 27/May/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch 'pr-233' into 1.2.0-dev
|
| Comment by Githook User [ 27/May/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch 'pr-233' into 1.2.0-dev
|
| Comment by Githook User [ 27/May/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Githook User [ 27/May/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by A. Jesse Jiryu Davis [ 19/May/15 ] |
|
Needs a mongoc_cluster_node_max_batch_size (cluster, hint), by analogy with mongoc_cluster_node_max_bson_obj_size. Low priority, however: the server always sends 1000 so far, which is the same as the hard-coded value in the driver, and if the server changes the maximum it will rise, not fall. Thus fixing this will eventually be a small performance improvement, and has no effect now. Wait for a nice mock_server_t rewrite to make this easy to test, rather than doing it urgently. |