[CDRIVER-547] inappropriate use of sasl_client_init and sasl_client_done Created: 26/Feb/15  Updated: 17/Aug/15  Resolved: 08/Jun/15

Status: Closed
Project: C Driver
Component/s: auth, libmongoc
Affects Version/s: 1.1.0
Fix Version/s: 1.2-beta0

Type: Bug Priority: Major - P3
Reporter: Mira Carey Assignee: A. Jesse Jiryu Davis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by CDRIVER-530 SASL version check does not do what y... Closed
Related
related to CDRIVER-731 Custom log handler cannot capture tra... Closed

 Description   

sasl_client_init() and sasl_client_done() are supposed to be global load/unload functions. We call them for each sasl connection we initialize, which seems wrong.

Also, sasl_client_init() and done() aren't thread safe... We should probably be running those in the driver init() / cleanup(). Also, take a look at whether we need sasl_set_mutex().



 Comments   
Comment by Githook User [ 05/Aug/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-547 fix sasl concurrency

(cherry picked from commit cd5c234b5b9a53ccef702936c3ba75f662dffab6)

Conflicts:
build/cmake/FindSASL2.cmake
Branch: 1.2.0-dev
https://github.com/mongodb/mongo-c-driver/commit/c3c14f431864c82f670581c0e380cef9047cfb96

Comment by Githook User [ 05/Aug/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-547 show that concurrent sasl fails
(cherry picked from commit 817fe03)
Branch: 1.2.0-dev
https://github.com/mongodb/mongo-c-driver/commit/b50a9df7eb49427a903b40a67d7a56c60248384a

Comment by Githook User [ 12/Jun/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-547 fix sasl concurrency
Branch: 1.2.0-dev
https://github.com/mongodb/mongo-c-driver/commit/cd5c234b5b9a53ccef702936c3ba75f662dffab6

Comment by Githook User [ 12/Jun/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-547 show that concurrent sasl fails
Branch: 1.2.0-dev
https://github.com/mongodb/mongo-c-driver/commit/817fe031c2101dcd6e643521ffa01d2a0ebe401e

Comment by Githook User [ 05/Jun/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-547 fix sasl concurrency

(cherry picked from commit cd5c234b5b9a53ccef702936c3ba75f662dffab6)

Conflicts:
build/cmake/FindSASL2.cmake
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/c3c14f431864c82f670581c0e380cef9047cfb96

Comment by Githook User [ 05/Jun/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-547 show that concurrent sasl fails
(cherry picked from commit 817fe03)
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/b50a9df7eb49427a903b40a67d7a56c60248384a

Generated at Wed Feb 07 21:09:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.