[CDRIVER-547] inappropriate use of sasl_client_init and sasl_client_done Created: 26/Feb/15 Updated: 17/Aug/15 Resolved: 08/Jun/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | auth, libmongoc |
| Affects Version/s: | 1.1.0 |
| Fix Version/s: | 1.2-beta0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Mira Carey | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
sasl_client_init() and sasl_client_done() are supposed to be global load/unload functions. We call them for each sasl connection we initialize, which seems wrong. Also, sasl_client_init() and done() aren't thread safe... We should probably be running those in the driver init() / cleanup(). Also, take a look at whether we need sasl_set_mutex(). |
| Comments |
| Comment by Githook User [ 05/Aug/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: (cherry picked from commit cd5c234b5b9a53ccef702936c3ba75f662dffab6) Conflicts: |
| Comment by Githook User [ 05/Aug/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 12/Jun/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 12/Jun/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 05/Jun/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: (cherry picked from commit cd5c234b5b9a53ccef702936c3ba75f662dffab6) Conflicts: |
| Comment by Githook User [ 05/Jun/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |