[CDRIVER-590] Support readPreference connection string option Created: 23/Mar/15 Updated: 08/Jan/24 Resolved: 08/Apr/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | 1.1.4 |
| Fix Version/s: | 1.2-beta0 |
| Type: | New Feature | Priority: | Major - P3 |
| Reporter: | Jeremy Mikola | Assignee: | Jeremy Mikola |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Comments |
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch 'pr-211' into 1.2.0-dev
|
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch 'pr-211' into 1.2.0-dev
|
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch 'pr-211' into 1.2.0-dev
|
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch 'pr-211' into 1.2.0-dev
|
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'jmikola', u'name': u'Jeremy Mikola', u'email': u'jmikola@gmail.com'}Message: This also corrects the documentation to note that only read preference tags are returned in the BSON result. |
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'jmikola', u'name': u'Jeremy Mikola', u'email': u'jmikola@gmail.com'}Message: This adds support for parsing the readPreference URI option. It also implements validation of the read preference and returns a NULL URI pointer on failure, similar to the write concern validation added by Unfortunately, mongoc_uri_get_read_prefs() was already taken for the API function that returns read preference tags from the URI. This commit adds a new function, mongoc_uri_get_read_prefs_t(), which returns the actual mongoc_read_prefs_t struct (now used by the client constructor). |
| Comment by Githook User [ 07/Apr/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch 'pr-211' into 1.2.0-dev
|
| Comment by Githook User [ 07/Apr/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch 'pr-211' into 1.2.0-dev
|
| Comment by Githook User [ 07/Apr/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch 'pr-211' into 1.2.0-dev
|
| Comment by Githook User [ 07/Apr/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch 'pr-211' into 1.2.0-dev
|
| Comment by Githook User [ 07/Apr/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 07/Apr/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 07/Apr/15 ] |
|
Author: {u'username': u'jmikola', u'name': u'Jeremy Mikola', u'email': u'jmikola@gmail.com'}Message: This also corrects the documentation to note that only read preference tags are returned in the BSON result. |
| Comment by Githook User [ 07/Apr/15 ] |
|
Author: {u'username': u'jmikola', u'name': u'Jeremy Mikola', u'email': u'jmikola@gmail.com'}Message: This adds support for parsing the readPreference URI option. It also implements validation of the read preference and returns a NULL URI pointer on failure, similar to the write concern validation added by Unfortunately, mongoc_uri_get_read_prefs() was already taken for the API function that returns read preference tags from the URI. This commit adds a new function, mongoc_uri_get_read_prefs_t(), which returns the actual mongoc_read_prefs_t struct (now used by the client constructor). |
| Comment by Jeremy Mikola [ 30/Mar/15 ] |
|
PR is updated to remove unnecessary bson_t on the URI struct, per mira.carey@mongodb.com's request. Additionally, I added new symbols/documentation and deprecated the old URI getter. There is one outstanding question in this thread about whether we want to abort URI initialization if the read preference is invalid (i.e. primary mode with tags), as we will do for invalid write concerns in 1.x once |
| Comment by Jeremy Mikola [ 24/Mar/15 ] |