[CDRIVER-593] Dozen strcasecmp checks should be merged Created: 25/Mar/15  Updated: 19/Oct/16  Resolved: 21/Nov/15

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: 1.2-beta0
Fix Version/s: 1.2-beta1

Type: Improvement Priority: Major - P3
Reporter: Hannes Magnusson Assignee: A. Jesse Jiryu Davis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

Windows doesn't have strcasecmp() so we have roughly a dozen or so inline checks for windows to define strcasecmp to _stricmp()

This really should be moved into compat check.



 Comments   
Comment by Githook User [ 11/Jan/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}

Message: Merge pull request #263 from ksuarz/CDRIVER-593-strcasecmp

CDRIVER-593 strcasecmp
Branch: 1.3.0-dev
https://github.com/mongodb/mongo-c-driver/commit/8c1dbd4d30e0e9eef600c08c9e34dc54fe082247

Comment by Githook User [ 11/Jan/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}

Message: Merge pull request #263 from ksuarz/CDRIVER-593-strcasecmp

CDRIVER-593 strcasecmp
Branch: 1.3.0-dev
https://github.com/mongodb/mongo-c-driver/commit/8c1dbd4d30e0e9eef600c08c9e34dc54fe082247

Comment by Githook User [ 11/Jan/16 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'ksuarz@gmail.com'}

Message: CDRIVER-593 add missing include
Branch: 1.3.0-dev
https://github.com/mongodb/mongo-c-driver/commit/bc2300a5c7958123529caa21bfd0a32329b838b2

Comment by Githook User [ 11/Jan/16 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'ksuarz@gmail.com'}

Message: CDRIVER-593 merge strcasecmp checks

Checks for strcasecmp and strncasecmp on Windows have been moved to
mongoc-util-private.h.
Branch: 1.3.0-dev
https://github.com/mongodb/mongo-c-driver/commit/ed951afad91c7b2f92883a0c665a5dc3f136dfb6

Comment by Githook User [ 20/Nov/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-593 duplicate strcasecmp #defines in tests
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/7d4dea794f4445740030cbd946a636a126f18820

Comment by Githook User [ 01/Sep/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}

Message: Merge pull request #263 from ksuarz/CDRIVER-593-strcasecmp

CDRIVER-593 strcasecmp
Branch: 1.2.0-dev
https://github.com/mongodb/mongo-c-driver/commit/8c1dbd4d30e0e9eef600c08c9e34dc54fe082247

Comment by Githook User [ 01/Sep/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}

Message: Merge pull request #263 from ksuarz/CDRIVER-593-strcasecmp

CDRIVER-593 strcasecmp
Branch: 1.2.0-dev
https://github.com/mongodb/mongo-c-driver/commit/8c1dbd4d30e0e9eef600c08c9e34dc54fe082247

Comment by Githook User [ 01/Sep/15 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'ksuarz@gmail.com'}

Message: CDRIVER-593 add missing include
Branch: 1.2.0-dev
https://github.com/mongodb/mongo-c-driver/commit/bc2300a5c7958123529caa21bfd0a32329b838b2

Comment by Githook User [ 01/Sep/15 ]

Author:

{u'username': u'ksuarz', u'name': u'Kyle Suarez', u'email': u'ksuarz@gmail.com'}

Message: CDRIVER-593 merge strcasecmp checks

Checks for strcasecmp and strncasecmp on Windows have been moved to
mongoc-util-private.h.
Branch: 1.2.0-dev
https://github.com/mongodb/mongo-c-driver/commit/ed951afad91c7b2f92883a0c665a5dc3f136dfb6

Generated at Wed Feb 07 21:09:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.