[CDRIVER-599] ./configure --disable-optimizations should not touch CFLAGS Created: 31/Mar/15 Updated: 08/Jan/24 Resolved: 26/Oct/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | 1.1.2 |
| Fix Version/s: | 1.3.0-beta0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Petr Pisar | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
glibc on Linux |
||
| Attachments: |
|
| Description |
|
./configure --disable-optimizations appends -O0 to CFLAGS. ./configure --enable-optimizations appends -O2. I'd like to see possibility not to change the optimization level at all. This is especially useful for distributions which want to build software uniformly with their own compiler flags. Attached patch changes --disable-optimizations to preserve CFLAGS. |
| Comments |
| Comment by Hannes Magnusson [ 26/Oct/15 ] |
|
Err. Missed amending your commit message to include the ticket# Its here though: https://github.com/mongodb/libbson/commit/70557dff8fa0dfb486eb8b2376556fb769f63ed5 Thanks for the fix! |
| Comment by Githook User [ 26/Oct/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: It is part of --enable-hardening which makes far more sense |
| Comment by Githook User [ 26/Oct/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |