[CDRIVER-601] libbson bundles YAJL library Created: 01/Apr/15 Updated: 03/May/17 Resolved: 01/Apr/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Petr Pisar | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Description |
|
It's good practise not to bundle foreign code. libbson-1.1.2 bundles YAJL library and uses it's internals not int the public YAJL API. Attached patch introduces a configure-time check for system YAJL library. If it's available, it is used instead of the bundled one. It would be good if libbson stopped using YAJL internals, or if you persuaded YAJL maintainers to publish API you need. |
| Comments |
| Comment by Petr Pisar [ 02/Apr/15 ] |
|
I probably forgot to attach it. Here it is. |
| Comment by A. Jesse Jiryu Davis [ 01/Apr/15 ] |
|
Thanks ppisar, I think this is a duplicate of YAJL needs to be more consistent about letting us configure its allocator ( |
| Comment by Hannes Magnusson [ 01/Apr/15 ] |
|
ppisar Did you forget to attach the patch? |