[CDRIVER-624] Fail build with GCC 5 Created: 22/Apr/15  Updated: 07/Oct/15  Resolved: 24/Apr/15

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: 1.1.4
Fix Version/s: 1.1.5

Type: Bug Priority: Major - P3
Reporter: Remi Collet Assignee: A. Jesse Jiryu Davis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Fedora 22 / GCC



 Description   

From configure output

configure: error: Compiler GCC >= 4.1 or Clang >= 3.3 is required for C compilation

From config.log

#if !(defined(_GNUC) && !defined(clang) && !defined(INTEL_COMPILER) && __GNUC_ >= 4 && _GNUC_MINOR_ >= 1)
#error Not a supported GCC compiler
#endif

This test is obviously wrong...



 Comments   
Comment by Githook User [ 07/Oct/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: Merge branch 'master' into 1.2.0-dev

  • master:
    add prerelease version to CMakeLists
    wrap version definitions in parens
    check for prerelease version with m4_ifset
    grammar
    CDRIVER-624 fix clang version check
    CDRIVER-624 fix gcc and clang version checks
    Silence CMake 3.0+ warning on Mac OS X.
    CDRIVER-613 remove GCC-specific min/max macros.

Conflicts:
CMakeLists.txt
build/autotools/Versions.m4
doc/version.page
Branch: master
https://github.com/mongodb/libbson/commit/ce961137ad3e51a2e3688a2e024dc1918f2f71be

Comment by Githook User [ 07/Oct/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: Merge branch 'master' into 1.2.0-dev

  • master:
    add prerelease version to CMakeLists
    wrap version definitions in parens
    check for prerelease version with m4_ifset
    grammar
    CDRIVER-624 fix clang version check
    CDRIVER-624 fix gcc and clang version checks
    Silence CMake 3.0+ warning on Mac OS X.
    CDRIVER-613 remove GCC-specific min/max macros.

Conflicts:
CMakeLists.txt
build/autotools/Versions.m4
doc/version.page
Branch: master
https://github.com/mongodb/libbson/commit/ce961137ad3e51a2e3688a2e024dc1918f2f71be

Comment by A. Jesse Jiryu Davis [ 25/Apr/15 ]

Thanks for confirming!

Comment by Remi Collet [ 25/Apr/15 ]

I confirm the above commit fix the build on Fedora 22 / GCC 5
Thanks

Comment by Githook User [ 24/Apr/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-624 fix clang version check
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/ab6035462725f7f2bc5f8287456479236ec632c4

Comment by Githook User [ 24/Apr/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-624 fix gcc and clang version checks
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/9cd2576effe2185a9cbfdad4a26c336a19dc7e8b

Comment by A. Jesse Jiryu Davis [ 24/Apr/15 ]

remi could you the code on master a try in GCC 5, please?

Comment by Githook User [ 24/Apr/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: CDRIVER-624 fix gcc and clang version checks
Branch: CDRIVER-624-fix-gcc-version-check
https://github.com/mongodb/mongo-c-driver/commit/9cd2576effe2185a9cbfdad4a26c336a19dc7e8b

Comment by A. Jesse Jiryu Davis [ 22/Apr/15 ]

Thanks for the report!

Comment by Remi Collet [ 22/Apr/15 ]

I forget to say, this is from build/autotools/CheckCompiler.m4

Generated at Wed Feb 07 21:10:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.