[CDRIVER-640] mongoc_client_get_database_names does not set error Created: 07/May/15 Updated: 17/Aug/15 Resolved: 28/May/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | 1.1.4 |
| Fix Version/s: | 1.2-beta0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Maverick Chan | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
mongoc_client_get_database_names does not set the bson_error_t struct or return NULL even if an error is encountered. If I change mongoc-client.c:1316 to:
then it looks like the error is set. A simple test case is connecting with an invalid user/pwd, then calling mongoc_client_get_database_names (should return NULL). |
| Comments |
| Comment by Githook User [ 05/Aug/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 29/May/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 28/May/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Properly sets bson_error_t and returns NULL on error. |
| Comment by Githook User [ 28/May/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by A. Jesse Jiryu Davis [ 09/May/15 ] |
|
Thanks for the report and the suggested fix! I noticed a similar bug in get_collection_names, |