[CDRIVER-698] Unused macro in libbson Created: 05/Jun/15 Updated: 03/May/17 Resolved: 18/Jun/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libbson |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Trivial - P5 |
| Reporter: | Jeroen Ooms [X] | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
The BSON_PTHREAD_ONCE_INIT_NEEDS_BRACES macro in libbson config.h does not seem to be used anywhere. Perhaps it can be removed. |
| Comments |
| Comment by Githook User [ 11/Jan/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch '1.2.0-dev'
|
| Comment by Githook User [ 20/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch '1.2.0-dev'
|
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch '1.2.0-dev'
|
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #132 from ajdavis/
|
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #132 from ajdavis/
|
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 07/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Merge branch '1.2.0-dev'
|
| Comment by A. Jesse Jiryu Davis [ 18/Jun/15 ] |
|
The macro wasn't used because there was a misspelled attempt to use it, with a comment about how it might be needed on Solaris 10. I don't have a Solaris 10 box handy to test whether the macro's really necessary, so I've fixed its usage in case it's needed, rather than deleting it. |
| Comment by Githook User [ 18/Jun/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #132 from ajdavis/
|
| Comment by Githook User [ 18/Jun/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #132 from ajdavis/
|
| Comment by Githook User [ 18/Jun/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by A. Jesse Jiryu Davis [ 17/Jun/15 ] |
| Comment by A. Jesse Jiryu Davis [ 05/Jun/15 ] |
|
Thanks for the info! |
| Comment by Jeroen Ooms [X] [ 05/Jun/15 ] |
|
I can confirm that it builds on both solaris 10 and 11 with BSON_PTHREAD_ONCE_INIT_NEEDS_BRACES = 0. So it seems completely redundant. |
| Comment by A. Jesse Jiryu Davis [ 05/Jun/15 ] |
|
The check in libbson's FindDependencies.m4 claims:
Yet the macro isn't used. Instead, we use a wrongly-spelled macro |