[CDRIVER-712] Unnecessary include in libbson bson-endian.h Created: 18/Jun/15  Updated: 03/May/17  Resolved: 23/Jun/15

Status: Closed
Project: C Driver
Component/s: libbson
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: David Hatch Assignee: A. Jesse Jiryu Davis
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible

 Description   

The inclusion of bson-types.h was introduced in https://github.com/mongodb/libbson/commit/fc825f569d7ad6158682f11503f53543d105426a. However, https://github.com/mongodb/libbson/commit/c14f75eadf3d9353e754165f31d9d2e1b5e7d70e removed the need for it, but it was not removed. This causes the unavailability of bson-endian.h macros if they are needed in bson-types.h.



 Comments   
Comment by Githook User [ 11/Jan/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: Merge branch '1.2.0-dev'

Comment by Githook User [ 20/Oct/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: Merge branch '1.2.0-dev'

Comment by Githook User [ 07/Oct/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: Merge branch '1.2.0-dev'

Comment by Githook User [ 07/Oct/15 ]

Author:

{u'username': u'dhatch', u'name': u'David Hatch', u'email': u'david.hatch@mongodb.com'}

Message: CDRIVER-712 bson-endian.h should not include bson-types.h.

The inclusion of bson-types.h was introduced in
https://github.com/mongodb/libbson/commit/fc825f569d7ad6158682f11503f53543d105426a.
However,
https://github.com/mongodb/libbson/commit/c14f75eadf3d9353e754165f31d9d2e1b5e7d70e
removed the need for it, but it was not removed. This causes the
unavailability of bson-endian.h macros if they are needed in
bson-types.h.
Branch: master
https://github.com/mongodb/libbson/commit/3420d4d2579941f509db8daff91ecb0cfb7daff9

Comment by Githook User [ 07/Oct/15 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}

Message: Merge branch '1.2.0-dev'

Comment by Githook User [ 23/Jun/15 ]

Author:

{u'username': u'dhatch', u'name': u'David Hatch', u'email': u'david.hatch@mongodb.com'}

Message: CDRIVER-712 bson-endian.h should not include bson-types.h.

The inclusion of bson-types.h was introduced in
https://github.com/mongodb/libbson/commit/fc825f569d7ad6158682f11503f53543d105426a.
However,
https://github.com/mongodb/libbson/commit/c14f75eadf3d9353e754165f31d9d2e1b5e7d70e
removed the need for it, but it was not removed. This causes the
unavailability of bson-endian.h macros if they are needed in
bson-types.h.
Branch: 1.2.0-dev
https://github.com/mongodb/libbson/commit/3420d4d2579941f509db8daff91ecb0cfb7daff9

Comment by A. Jesse Jiryu Davis [ 23/Jun/15 ]

https://github.com/mongodb/libbson/pull/133

Comment by David Hatch [ 18/Jun/15 ]

Pull request: https://github.com/mongodb/libbson/pull/133

Generated at Wed Feb 07 21:10:24 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.