[CDRIVER-720] iter should stay the same after bson_iter_recurse() Created: 24/Jun/15  Updated: 03/May/17  Resolved: 13/Oct/16

Status: Closed
Project: C Driver
Component/s: docs, libbson
Affects Version/s: 1.1.8
Fix Version/s: None

Type: Bug Priority: Minor - P4
Reporter: Peng Xie Assignee: Backlog - C Driver Team
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The return section in the document of bson_iter_recurse() says:

Returns

true if child has been intialized. Otherwise, both child and iter should be considered invalid.

As iter is passed in as a const variable, it should not go bad. The document needs an update.



 Comments   
Comment by A. Jesse Jiryu Davis [ 13/Oct/16 ]

The behavior was always correct, in fact: "child" is invalid and "iter" is unmodified. The documentation was wrong but it was fixed in the pull request.

Comment by Githook User [ 30/Jul/16 ]

Author:

{u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}

Message: Merge pull request #134 from mapx/patch-2

CDRIVER-720 iter should stay the same after bson_iter_recurse() (Correct its document)
Branch: master
https://github.com/mongodb/libbson/commit/65d364b7d30cd54279bd08482d80699e7278f1d0

Comment by A. Jesse Jiryu Davis [ 16/Oct/15 ]

No, sorry. Watch this ticket for updates: it's still marked "unresolved" and the fix version is scheduled to be 1.3.0.

Thanks.

Comment by Peng Xie [ 16/Oct/15 ]

libbson 1.2.0 has been released with the conflict.
Is the behavior fixed?

Comment by A. Jesse Jiryu Davis [ 24/Jun/15 ]

Thanks for the report, I agree about the behavior. I think perhaps the behavior should be fixed in 1.2.0, rather than just updating the docs.

Generated at Wed Feb 07 21:10:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.