[CDRIVER-804] Use int64_t for timeouts consistently Created: 12/Aug/15 Updated: 03/May/17 Resolved: 14/Aug/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
There are a number of places that timeouts are handled as signed 32-bit millisecond values. This invites overflows if the timeout is over 36 minutes:
This particular bug can be fixed with:
... until the next time we make the same mistake. Change all timeout_msec values to int64_t. |
| Comments |
| Comment by Githook User [ 14/Aug/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 14/Aug/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: Stopgap until all timeout arguments are upgraded to int64_t. |
| Comment by A. Jesse Jiryu Davis [ 13/Aug/15 ] |
|
Can't be completely fixed this sprint, but we can make progress. |