[CDRIVER-807] Remove secondary-ok commands whitelist Created: 15/Aug/15 Updated: 03/May/16 Resolved: 08/Oct/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | 1.3.0-beta0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Description |
|
With the new Server Selection Spec, there is no longer a list of "secondary-ok" commands, and commands not in that list, when executed with a non-"primary" read preference, are no longer silently routed to the primary. On the other hand, the read preference configured on the client, database, or collection object no longer applies to commands executed with a generic command helper: Delete gSecondaryOkCommands: ... and review the functions mongoc_client_command, etc., for compliance with the spec. |
| Comments |
| Comment by Githook User [ 03/May/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: |
| Comment by Githook User [ 08/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: All commands now obey read preference. |
| Comment by A. Jesse Jiryu Davis [ 08/Sep/15 ] |
|
Update here: https://github.com/mongodb/mongo-c-driver/blob/1.2.0-beta1/src/mongoc/mongoc-cursor.c#L143 ... and remove special-casing for aggregate with "$out" and mapreduce with "out". |