[CDRIVER-831] GCC 5 warnings Created: 07/Sep/15 Updated: 11/Jan/16 Resolved: 23/Oct/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.3.0-beta0 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Jeroen Ooms [X] | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
A few days ago Debian testing changed to use GCC 5 (actually, 5.2 with
|
| Comments |
| Comment by Githook User [ 11/Jan/16 ] | |||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||||
| Comment by Githook User [ 11/Jan/16 ] | |||||
|
Author: {u'username': u'jeroenooms', u'name': u'Jeroen Ooms', u'email': u'jeroenooms@gmail.com'}Message: | |||||
| Comment by Githook User [ 28/Oct/15 ] | |||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||||
| Comment by Githook User [ 28/Oct/15 ] | |||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||||
| Comment by Githook User [ 28/Oct/15 ] | |||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||||
| Comment by Hannes Magnusson [ 23/Oct/15 ] | |||||
|
Thanks! | |||||
| Comment by Githook User [ 23/Oct/15 ] | |||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Bump libbson after adding BSON_FUNC for | |||||
| Comment by Githook User [ 23/Oct/15 ] | |||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||||
| Comment by Githook User [ 23/Oct/15 ] | |||||
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: | |||||
| Comment by Githook User [ 23/Oct/15 ] | |||||
|
Author: {u'username': u'jeroenooms', u'name': u'Jeroen Ooms', u'email': u'jeroenooms@gmail.com'}Message: | |||||
| Comment by Jeroen Ooms [X] [ 16/Oct/15 ] | |||||
| Comment by A. Jesse Jiryu Davis [ 07/Sep/15 ] | |||||
|
The driver needs to compile under all conceivable configurations: C89, C99, C++, Microsoft, GCC 4, GCC 5, Clang, .... It seems like something like this is best, in bson-macros.h in the libbson repo on the 1.3.0-dev branch:
... and replace "__FUNCTION__" with "BSON_FUNC" everywhere in libbson. Once we've got that working, we can use BSON_FUNC in mongo-c-driver too, also on the 1.3.0-dev branch. | |||||
| Comment by Jeroen Ooms [X] [ 07/Sep/15 ] | |||||
|
What approach should I take? Replace all occurences of
| |||||
| Comment by A. Jesse Jiryu Davis [ 07/Sep/15 ] | |||||
|
Thanks Jeroen, would you like to submit a pull request? | |||||
| Comment by Jeroen Ooms [X] [ 07/Sep/15 ] | |||||
|
This issue is actually documented in the porting to gcc 5 manual under "New Warnings":
|