[CDRIVER-843] WSASend incorrect error checking Created: 15/Sep/15 Updated: 19/Oct/16 Resolved: 28/Sep/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | None |
| Affects Version/s: | 1.1.10 |
| Fix Version/s: | 1.2-rc0, 1.1.11 |
| Type: | Bug | Priority: | Blocker - P1 |
| Reporter: | Hannes Magnusson | Assignee: | Hannes Magnusson |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
On Windows we use WSASend() to send iovecs. There is a lot of type mangling going on there for the error check and eventual return type of mongoc_socket_try_sendv(). This needs to be updated to use clean types and explicit error checking. We also need to check the result for SOCKET_ERROR as per the docs: https://msdn.microsoft.com/en-us/library/windows/desktop/ms742203%28v=vs.85%29.aspx |
| Comments |
| Comment by Githook User [ 11/Jan/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Conflicts: |
| Comment by Githook User [ 11/Jan/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Use int for WSASend() and debug both return value and sent bytes Conflicts: |
| Comment by Githook User [ 11/Jan/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #267 from bjori/master
|
| Comment by Githook User [ 11/Jan/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Githook User [ 11/Jan/16 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Use int for WSASend() and debug both return value and sent bytes |
| Comment by Githook User [ 26/Oct/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Conflicts: |
| Comment by Githook User [ 26/Oct/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Use int for WSASend() and debug both return value and sent bytes Conflicts: |
| Comment by Githook User [ 26/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #267 from bjori/master
|
| Comment by Githook User [ 26/Oct/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Githook User [ 26/Oct/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Use int for WSASend() and debug both return value and sent bytes |
| Comment by Githook User [ 28/Sep/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #267 from bjori/master
|
| Comment by Githook User [ 28/Sep/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Githook User [ 28/Sep/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Use int for WSASend() and debug both return value and sent bytes |
| Comment by Githook User [ 16/Sep/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Conflicts: |
| Comment by Githook User [ 16/Sep/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Use int for WSASend() and debug both return value and sent bytes Conflicts: |
| Comment by Githook User [ 16/Sep/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@emptysquare.net'}Message: Merge pull request #267 from bjori/master
|
| Comment by Githook User [ 16/Sep/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: |
| Comment by Githook User [ 16/Sep/15 ] |
|
Author: {u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}Message: Use int for WSASend() and debug both return value and sent bytes |
| Comment by Hannes Magnusson [ 16/Sep/15 ] |