[CDRIVER-846] Refactor _mongoc_write_command_insert_append Created: 16/Sep/15 Updated: 19/Oct/16 Resolved: 16/Sep/15 |
|
| Status: | Closed |
| Project: | C Driver |
| Component/s: | Bulk API, libmongoc |
| Affects Version/s: | None |
| Fix Version/s: | 1.2-rc0 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | A. Jesse Jiryu Davis | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
_mongoc_write_command_init_insert and _mongoc_write_command_insert_append differ unnecessarily from the equivalent helper functions for update and remove: the insert functions take an array of documents instead of a single document. (The inconsistency dates from the implementation of mongoc_collection_insert_bulk, now deprecated. In any case, mongoc_collection_insert_bulk can be responsible for handling an array of documents instead of pushing that chore down the call stack.) |
| Comments |
| Comment by Githook User [ 11/Jan/16 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: _mongoc_write_command_init_insert and _mongoc_write_command_insert_append (The inconsistency dates from the implementation of |
| Comment by Githook User [ 26/Oct/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: _mongoc_write_command_init_insert and _mongoc_write_command_insert_append (The inconsistency dates from the implementation of |
| Comment by Githook User [ 16/Sep/15 ] |
|
Author: {u'username': u'ajdavis', u'name': u'A. Jesse Jiryu Davis', u'email': u'jesse@mongodb.com'}Message: _mongoc_write_command_init_insert and _mongoc_write_command_insert_append (The inconsistency dates from the implementation of |