[CDRIVER-890] mongoc_cluster_node_reconnect must always destroy server description? Created: 29/Sep/15  Updated: 11/Sep/19  Resolved: 30/Sep/15

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Kyle Suarez Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Mac OSX Yosemite


Issue Links:
Related
related to CDRIVER-830 Exhaust cursors must destroy the stre... Closed
is related to CDRIVER-868 Leak in mongoc_cluster_node_reconnect Closed

 Description   

On a call to mongoc_cluster_node_reconnect() in mongoc-cluster.c, is it possible for

  • topology->single_threaded and
  • !(scanner_node->stream && cluster->requires_auth)

to be true at the same time? Then mongoc_server_description_t *sd won't be set, but the function unconditionally calls mongoc_server_description_destroy() on function exit.



 Comments   
Comment by Kyle Suarez [ 30/Sep/15 ]

The tests pass after that commit, so let's close this.

Comment by A. Jesse Jiryu Davis [ 30/Sep/15 ]

kyle.suarez is this still an issue after this?: https://github.com/mongodb/mongo-c-driver/commit/73f04b86

Generated at Wed Feb 07 21:10:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.