[CDRIVER-950] BSON_PTHREAD_ONCE_INIT_NEEDS_BRACES redefined Created: 21/Oct/15  Updated: 19/Oct/16  Resolved: 21/Oct/15

Status: Closed
Project: C Driver
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2.1

Type: Bug Priority: Major - P3
Reporter: Hannes Magnusson Assignee: Hannes Magnusson
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

The BSON_PTHREAD_ONCE_INIT_NEEDS_BRACES checks seems broken:

./src/bson/bson-config.h:49:0: warning: "BSON_PTHREAD_ONCE_INIT_NEEDS_BRACES" redefined [enabled by default]

When its supposed to be used, it is passed as a compiler option -DBSON_PTHREAD_ONCE_INIT_NEEDS_BRACES and incorrectly (unconditionally) set to 0 in our bson-config.h[.in] (hence the warning), which results in it being undef'd in bson-config.h.



 Comments   
Comment by Githook User [ 11/Jan/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-950: BSON_PTHREAD_ONCE_INIT_NEEDS_BRACES redefined
Branch: 1.3.0-dev
https://github.com/mongodb/libbson/commit/c4abd16d832f46b8a8d8328521684e3015b6b06f

Comment by Githook User [ 22/Oct/15 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-950: BSON_PTHREAD_ONCE_INIT_NEEDS_BRACES redefined
Branch: master
https://github.com/mongodb/libbson/commit/c4abd16d832f46b8a8d8328521684e3015b6b06f

Comment by Githook User [ 21/Oct/15 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-950: BSON_PTHREAD_ONCE_INIT_NEEDS_BRACES redefined
Branch: r1.2
https://github.com/mongodb/libbson/commit/c4abd16d832f46b8a8d8328521684e3015b6b06f

Comment by Hannes Magnusson [ 21/Oct/15 ]

https://mongodbcr.appspot.com/32260001/

Generated at Wed Feb 07 21:11:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.