[CDRIVER-989] "make install" installs private headers Created: 06/Nov/15  Updated: 19/Oct/16  Resolved: 02/Sep/16

Status: Closed
Project: C Driver
Component/s: Build, libmongoc
Affects Version/s: None
Fix Version/s: 1.5.0

Type: Bug Priority: Major - P3
Reporter: A. Jesse Jiryu Davis Assignee: Hannes Magnusson
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

libmongoc's "make install" copies two dozen private header files into the system include path, which encourages developers to depend on private, unstable API/ABI:

https://github.com/mongodb/mongo-c-driver/blob/1.2.1/src/mongoc/Makefile.am#L19

libmongoc should omit private headers from the installed files, like libbson does:

https://github.com/mongodb/libbson/blob/1.2.1/src/bson/Makefile.am#L8



 Comments   
Comment by Githook User [ 27/Sep/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-989 These files still need to be in the release archive
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/8fb2f193051ad148cb14927e984b30b467236abb

Comment by Githook User [ 02/Sep/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-989 Do not include private header in public header
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/1e60b28923d9cca888d97c8e15a18a54bb49d609

Comment by Githook User [ 02/Sep/16 ]

Author:

{u'username': u'bjori', u'name': u'Hannes Magnusson', u'email': u'bjori@php.net'}

Message: CDRIVER-989 "make install" installs private headers
Branch: master
https://github.com/mongodb/mongo-c-driver/commit/8254e8e5f18827c27b7ad02008e76350ab91fe30

Generated at Wed Feb 07 21:11:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.