[COMPASS-1734] hadron-build is not checking for eslint warnings Created: 14/Aug/17  Updated: 10/Jan/24  Resolved: 13/Nov/19

Status: Closed
Project: Compass
Component/s: Packaging
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Peter Schmidt Assignee: Unassigned
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2017-08-14 at 5.56.08 pm.png    
Epic Link: COMPASS-2228

 Description   

hadron-build is not running eslint against commands, such as the release command.

In Compass, this is done by passing the paths to check to mongodb-js-precommit.

An example usage based on the Compass one thus might be:

mongodb-js-precommit './commands/**/*.js' 'test/**/*.js' cli.js index.js

Which generates the following warnings:

Aside: Example debug output reveals the paths that are inspected by default:

  mongodb-js-precommit resolving paths for globs:
  mongodb-js-precommit  ["./bin/*.js","./lib/{**/*,*}.js","./examples/{**/*,*}.js","./src/{**/*,*}.js","./test/{**/*,*}.js","./*.js"] +0ms
  mongodb-js-precommit resolving `./bin/*.js`... +1ms
  mongodb-js-precommit resolving `./lib/{**/*,*}.js`... +4ms
  mongodb-js-precommit resolving `./examples/{**/*,*}.js`... +2ms
  mongodb-js-precommit resolving `./src/{**/*,*}.js`... +0ms
  mongodb-js-precommit resolving `./test/{**/*,*}.js`... +1ms
  mongodb-js-precommit resolving `./*.js`... +0ms
  mongodb-js-precommit resolved 0 file(s) for `./bin/*.js` +1ms
  mongodb-js-precommit resolved 0 file(s) for `./examples/{**/*,*}.js` +2ms
  mongodb-js-precommit resolved 0 file(s) for `./src/{**/*,*}.js` +1ms
  mongodb-js-precommit resolved 2 file(s) for `./*.js` +4ms
  mongodb-js-precommit resolved 6 file(s) for `./lib/{**/*,*}.js` +0ms
  mongodb-js-precommit resolved 12 file(s) for `./test/{**/*,*}.js` +74ms
  mongodb-js-precommit checking and removing duplicate paths... +1ms
  mongodb-js-precommit final result has `20` files +0ms
...


Generated at Wed Feb 07 22:28:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.