[COMPASS-3060] cmd-f: show current and total results in search window Created: 14/Aug/18 Updated: 01/Dec/22 Resolved: 01/Dec/22 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | Navigation, UI / UX |
| Affects Version/s: | None |
| Fix Version/s: | No version |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Irina Shestak (Inactive) | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | find-in-page, needs-ux-feedback | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Documentation Changes: | Not Needed |
| Description |
|
When results come in from webContents' found-in-page, results should be passed in to the find in page component to display. Work was already started in compass itself – https://github.com/10gen/compass/pull/1516/files#diff-0e11dce1f362126351f65bee8178cbadR198 Find in Page component also has some work that was started – https://github.com/mongodb-js/compass-find-in-page/blob/master/src/stores/store.js#L21-L24 ---------------------------------------------------- A few resources to help along the way:
Beaker browser implements find in page – html , where the result is set here in js A find in page example (it's in typescript tho) – handing result specifically A webview implementation of find in page – handling results |