[COMPASS-3199] spike: investigate stream usage in our stream using modules Created: 15/Oct/18  Updated: 13/Nov/19  Resolved: 13/Nov/19

Status: Closed
Project: Compass
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Minor - P4
Reporter: Irina Shestak (Inactive) Assignee: Lucas Hrabovsky (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

There were some recent additions to Node 10.x stream implementation that we should look into fixing in our JSON/CSV imports (i think that's the module with a heavy stream usage?):

  • need to stop doing "stream.emit('error')" (if we are doing that) and use "stream.destroy()"
  • ^ destroy wasn't actually properly destroying in pre-10.x
  • destroy is currently not being called internally on 'end' and 'finish'; see if we are relying on this to happen.
  • there are no longer events emitted after 'close', so we should double check we are using that properly


 Comments   
Comment by Lucas Hrabovsky (Inactive) [ 13/Nov/19 ]

Thanks for tracking this! COMPASS-3853 took all of these points into account

Generated at Wed Feb 07 22:32:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.