[COMPASS-3235] Eliminate multiple keychain password requests Created: 06/Nov/18 Updated: 29/Oct/23 Resolved: 10/Sep/19 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | Connectivity, Favorites, Security |
| Affects Version/s: | 1.19.0 |
| Fix Version/s: | 1.20.0 |
| Type: | Task | Priority: | Critical - P2 |
| Reporter: | Lucas Hrabovsky (Inactive) | Assignee: | Durran Jordan |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | security | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Epic Link: | COMPASS-3417 | ||||||||||||||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||||||||||||||
| Documentation Changes: | Needed | ||||||||||||||||||||||||||||||||
| Documentation Changes Summary: | It's worth including in the release notes for Compass 1.20 that on OSX, after the upgrade, Compass will ask for the keychain password a few times (depending on the number of favorites). In this release, we changed the process that loads the favorites and our expectation is that this is the last time the user will have to enter their keychain password after an update. |
||||||||||||||||||||||||||||||||
| Sprint: | Iteration Bison, Iteration Manatee | ||||||||||||||||||||||||||||||||
| Description |
|
The multiple keychain password prompt has been a long-running unexplained behavior we haven't been able to get to the bottom of. A roll-up of bug reports: My hunch after re-reading these tickets is this happens after an auto-update or a manual upgrade. What's most likely is that we simply need to call keytar methods from the main process via ipc rather than from the renderer as we do today. See this example on stackoverflow.
More notes from previous tickets rolled up below. — SecKeychainFindGenericPassword, which is the method keytar uses to read a stored connection password. In the discussion:
A few ideas on what might need to happen:
|
| Comments |
| Comment by Eliezer Steinbock [ 13/Aug/19 ] |
|
This still seems to be an issue. Since downloading 1.19.0 I cannot use Compass anymore. It keeps asking for keychain password. |
| Comment by Durran Jordan [ 09/Apr/19 ] |
|
Have not seen this on master in a few weeks. |
| Comment by Githook User [ 29/Mar/19 ] |
|
Author: {'email': 'durran@gmail.com', 'name': 'Durran Jordan', 'username': 'durran'}Message: The connection model version was not updated in the data-service to the This fixes that issue, and also removes the cyclic dependency between This also brings the keytar versions in the data-service and Compass in |
| Comment by Githook User [ 29/Mar/19 ] |
|
Author: {'email': 'durran@gmail.com', 'name': 'Durran Jordan', 'username': 'durran'}Message: The connection model version was not updated in the data-service to the This fixes that issue, and also removes the cyclic dependency between This also brings the keytar versions in the data-service and Compass in |