[COMPASS-3546] Connection Model Not Setting Username and Password Created: 29/Mar/19  Updated: 29/Oct/23  Resolved: 29/Mar/19

Status: Closed
Project: Compass
Component/s: Connectivity
Affects Version/s: 1.19.0
Fix Version/s: 1.19.0

Type: Bug Priority: Blocker - P1
Reporter: Durran Jordan Assignee: Durran Jordan
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: Iteration Antelope

 Description   

The uri generated by the connection model is not longer setting a username and password in Compass.



 Comments   
Comment by Githook User [ 29/Mar/19 ]

Author:

{'email': 'durran@gmail.com', 'name': 'Durran Jordan', 'username': 'durran'}

Message: COMPASS-3546: Fix Connections Requiring Password:

The connection model version was not updated in the data-service to the
models that both Compass and the data-service were using were actually
different. Compass was using an extended model and the data-service was
using the old undecorated model. This meant where the actuall connection
was happening in the data-service the model was not properly retrieving
the username and password from the secure storage.

This fixes that issue, and also removes the cyclic dependency between
the extended connection model and the data-service. The #test method was
not used in Compass thus the data-service connection testing
functionality in the model itself was no longer needed. This must only
happen in the data service.

This also brings the keytar versions in the data-service and Compass in
line. Could potentially fix COMPASS-3235. I don't see this behaviour
anymore but will give it some time. This also fixes the tests in the
data-service since the electron require in the extended models now
protect against failure to load electron in pure node envs.
Branch: master
https://github.com/10gen/compass/commit/79c7a05b35a123c7d17aec51e9b5671209939ded

Comment by Githook User [ 29/Mar/19 ]

Author:

{'email': 'durran@gmail.com', 'name': 'Durran Jordan', 'username': 'durran'}

Message: COMPASS-3546: Fix Connections Requiring Password:

The connection model version was not updated in the data-service to the
models that both Compass and the data-service were using were actually
different. Compass was using an extended model and the data-service was
using the old undecorated model. This meant where the actuall connection
was happening in the data-service the model was not properly retrieving
the username and password from the secure storage.

This fixes that issue, and also removes the cyclic dependency between
the extended connection model and the data-service. The #test method was
not used in Compass thus the data-service connection testing
functionality in the model itself was no longer needed. This must only
happen in the data service.

This also brings the keytar versions in the data-service and Compass in
line. Could potentially fix COMPASS-3235. I don't see this behaviour
anymore but will give it some time. This also fixes the tests in the
data-service since the electron require in the extended models now
protect against failure to load electron in pure node envs.
Branch: fix-connect
https://github.com/10gen/compass/commit/913f64c8c13d5482bb1a1c45a918f5a9dcf4d633

Comment by Githook User [ 29/Mar/19 ]

Author:

{'name': 'Durran Jordan', 'username': 'durran', 'email': 'durran@gmail.com'}

Message: COMPASS-3546: Fixing dependencies and connection model
Branch: master
https://github.com/mongodb-js/data-service/commit/25a955574822a1bb393e31c491c3e0027ce38461

Generated at Wed Feb 07 22:33:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.