[COMPASS-3933] Update to Electron 6 Created: 16/Oct/19  Updated: 29/Oct/23  Resolved: 29/Jan/20

Status: Closed
Project: Compass
Component/s: None
Affects Version/s: None
Fix Version/s: 1.21.0

Type: Task Priority: Major - P3
Reporter: Durran Jordan Assignee: Lucas Hrabovsky (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on NODE-2253 Provide Ability to Generate and Parse... Closed
is depended on by COMPASS-4069 Update ssh2 dependency Closed
is depended on by COMPASS-4098 Upgrade to electron 13 Closed
Related
related to COMPASS-2407 When using SSH tunnel, COMPASS does n... Closed
related to COMPASS-4033 devDependency housekeeping across all... Closed
Story Points: 5
Sprint: Iteration Python, Iteration Tarantula, Iteration Ragamuffin, Iteration Snake, Iteration Urial, Iteration Vicuña

 Description   

Update to Electron 6 with latest Keytar.



 Comments   
Comment by Githook User [ 03/Feb/20 ]

Author:

{'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}

Message: build: COMPASS-4127: Fix code signing on Windows (#1895)

Evergreen:
https://evergreen.mongodb.com/version/5e386060e3c3311158f8f2e2

    1. Todo
    1. Description

Rollback `electron-winstaller` to `2.5.1` for now. Don't upgrade until [BUILD-2932](https://jira.mongodb.org/browse/BUILD-2932) is done.

    1. Notes

[Evergreen windows builds](https://evergreen.mongodb.com/task/10gen_compass_master_windows_package_and_publish_compass_3d7b0895c3d7ed4aada6f997286a8a57d7f835b5_20_01_31_17_33_22) started failing with the electron 6 update:

```
[2020/01/31 12:47:29.021] × Error: Error: Failed with exit code: 4294967295

[2020/01/31 12:47:29.021] Output:
[2020/01/31 12:47:29.021] System.AggregateException: One or more errors occurred. ---> System.Exception: Failed to sign, command invoked was: '.\signtool.exe sign yes C:\Users\mci-exec\AppData\Local\SquirrelTemp\tempa\lib\net45\ffmpeg.dll'
[2020/01/31 12:47:29.021] at Squirrel.Update.Program.<signPEFile>d__17.MoveNext()
```

Normally, `Failed with exit code: 4294967295` means [the signtool.exe notary service client](https://jira.mongodb.org/browse/BUILD-920) is getting a 500 service error due to an outage.

However, all other OS were signing with no issues [see BUILD-10250](https://jira.mongodb.org/browse/BUILD-10250).

```
cd /cygdrive/z/data/mci/src/dist/MongoDBCompassDev-win32-x64;

$ ../../signtool.exe sign yes ffmpeg.dll
2020/02/03 16:34:55 Signing service didn't return a permalink

$ ../../signtool.exe sign yes libEGL.dll
2020/02/03 16:35:14 Signing service didn't return a permalink

$ ../../signtool.exe sign yes MongoDBCompassDev.exe
Worked
$ ../../signtool.exe sign yes Squirrel.exe
Worked
```

So, it can't be a service issue and must be something related to the changes to `hadron-build` for COMPASS-3933 electron 6 support.

Only a handful of commits and [e3ff85c9303bc43e56976226d10d6b9897324b66](https://github.com/mongodb-js/hadron-build/commit/e3ff85c9303bc43e56976226d10d6b9897324b66)
`electron-winstaller` was upgraded from `2.5.1` to `4.0.0`. This changed the effective version of the [Squirrel.Windows](https://github.com/Squirrel/Squirrel.Windows) framework electron uses for win32 auto-update:

In `electron-winstaller@2.5.2` :arrow_right: [squirrel.windows@1.5.2](https://github.com/Squirrel/Squirrel.Windows/releases/tag/1.5.2):

> ### Releasify now disallows non-Semver versions
>
> While using non-Semver versions in your NuGet package was always incorrect and resulted in undefined behavior, due to #868, these are now a full non-starter. We now require packages to have Semver-compatible versions names. Note that this doesn't affect your EXE versions, which can still use all four Win32 version numbers.
>
> ### Bug Fixes
>
> - Allow uppercase characters in SemVer versions (#924, thanks)
> - Sign DLL and .node files during Releasify
> - Ensure that Stub Executables pass along their parameters to the target

And now the facepalm moment; [BUILD-2932](https://jira.mongodb.org/browse/BUILD-2932) (created in 2017) as the notary service doesn't support dll signing the way we need it to.

    1. Motivation and Context
  • [x] Dependency update
    1. Dependents

mongodb-js/hadron-build#110

    1. Types of changes
Comment by Githook User [ 29/Jan/20 ]

Author:

{'username': 'durran', 'name': 'Durran Jordan', 'email': 'durran@gmail.com'}

Message: COMPASS-3933: Update to Electron 6.0.11 (#1873)

  • chore(ci): Update node version on travis and evergreen
  • chore: Remove unused jsfmt config

Switched to prettier ages ago

  • hadron-build@23.0.2: ensure gnome-keyring is set as a requirement for debian OSs
  • build(deps): COMPASS-3933: Update to latest connect and query history plugins
      1. compass-query-history@7
  • COMPASS-3933 COMPASS-4072: Electron 6 and lodash updates mongodb-js/compass-query-history#41
  • build(deps-dev): COMPASS-4098: bump electron from 6.1.7 to 7.1.9 mongodb-js/compass-query-history#47
      1. compass-connect@5.3.2
  • COMPASS-4104 urlencode credentials when using X509
  • mongodb-js/compass-connect#82 chore: update dependencies for driver 3.4 and electron 6 COMPASS-4017
  • [x] mongodb-js/compass-explain-plan#17
  • [x] mongodb-js/compass-explain-plan#33
  • update dev deps
  • remove dupe deps from compass-schema
  • more extraneous deps
  • :arrow_up: export to lang, crud, schema validation
  • latest language model
  • COMPASS-3933: latest agg plugin mongodb-js/compass-aggregations#120
  • build(deps): source app-migrations from npm instead of github
  • build(deps): latest hadron*

hadron-app@latest hadron-app-registry@latest hadron-compile-cache@latest hadron-document@latest hadron-module-cache@latest

  • build(deps): Update all mongodb* to latest
  • mongodb-ace-autocompleter@0.4.1
  • mongodb-extended-json@1.11.0
  • mongodb-connection-model@14.4.3
  • mongodb-js-metrics@5.0.0
  • mongodb-language-model@1.6.1
  • mongodb-explain-plan-model@0.2.3
  • mongodb-ace-mode@0.4.1
  • mongodb@3.5.2
  • mongodb-data-service@16.4.0
  • mongodb-query-parser@2.0.0
  • mongodb-schema@8.2.5
  • mongodb-query-util@0.2.1
  • mongodb-collection-model@3.1.0
  • mongodb-ns@2.2.0

Co-authored-by: Lucas Hrabovsky <hrabovsky.lucas@gmail.com>
Co-authored-by: Irina Shestak <lrlna@users.noreply.github.com>
Branch: master
https://github.com/mongodb-js/compass/commit/3165b47084df3a25ac975171968ca5325d3bebe9

Comment by Githook User [ 29/Jan/20 ]

Author:

{'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}

Message: Merge branch 'master' into COMPASS-3933
Branch: COMPASS-3933
https://github.com/mongodb-js/compass/commit/7f1947d88a12c394ae3dfe266e0e4b2b53fd7b0c

Comment by Githook User [ 29/Jan/20 ]

Author:

{'username': 'imlucas', 'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com'}

Message: COMPASS-3933: latest crud
Branch: COMPASS-3933
https://github.com/mongodb-js/compass/commit/974db388e6c8d942f93cdf0644ade975451bc996

Comment by Githook User [ 28/Jan/20 ]

Author:

{'email': 'hrabovsky.lucas@gmail.com', 'name': 'Lucas Hrabovsky', 'username': 'imlucas'}

Message: COMPASS-3933: latest agg plugin mongodb-js/compass-aggregations#120
Branch: COMPASS-3933
https://github.com/mongodb-js/compass/commit/5971c4b5463c3cd66cb9992ea841d6371fcbad85

Comment by Githook User [ 27/Jan/20 ]

Author:

{'username': 'imlucas', 'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com'}

Message: COMPASS-3933: Latest metrics and others
Branch: COMPASS-3933
https://github.com/mongodb-js/compass/commit/4b66bcdb2dec4b40a72e28941db3d480f42ef457

Comment by Githook User [ 22/Jan/20 ]

Author:

{'username': 'imlucas', 'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com'}

Message: Merge branch 'master' into COMPASS-3933
Branch: COMPASS-3933
https://github.com/mongodb-js/compass/commit/0cff77ef7649f668deb0faa6bbb86f0a074c94fd

Comment by Githook User [ 22/Jan/20 ]

Author:

{'username': 'imlucas', 'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com'}

Message: build(deps): COMPASS-3933 update compass-explain-plan

Comment by Githook User [ 22/Jan/20 ]

Author:

{'email': 'hrabovsky.lucas@gmail.com', 'username': 'imlucas', 'name': 'Lucas Hrabovsky'}

Message: build(deps): COMPASS-3933: Update to latest connect and query history plugins

      1. compass-query-history@7
  • COMPASS-3933 COMPASS-4072: Electron 6 and lodash updates mongodb-js/compass-query-history#41
  • build(deps-dev): COMPASS-4098: bump electron from 6.1.7 to 7.1.9 mongodb-js/compass-query-history#47
      1. compass-connect@5.3.2
Comment by Githook User [ 15/Jan/20 ]

Author:

{'name': 'dependabot-preview[bot]', 'email': '27856297+dependabot-preview[bot]@users.noreply.github.com', 'username': 'dependabot-preview[bot]'}

Message: fix(deps): COMPASS-3933: Bump bson from 4.0.1 to 4.0.3 (#221)

Bumps [bson](https://github.com/mongodb/js-bson) from 4.0.1 to 4.0.3.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Branch: master
https://github.com/mongodb-js/connection-model/commit/4db6581ec3692cabd3ac68f5d628966cf4c71154

Comment by Githook User [ 15/Jan/20 ]

Author:

{'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com', 'username': 'imlucas'}

Message: Merge branch 'master' into COMPASS-3933
Branch: COMPASS-3933
https://github.com/mongodb-js/compass/commit/f233a4b287e3a42aab8f4823ce9b817bcb4682de

Comment by Githook User [ 06/Jan/20 ]

Author:

{'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com', 'username': 'imlucas'}

Message: feat: COMPASS-3933: Upgrade to Electron 6 (#160)

  • chore: Cleanup
  • update dependencies
  • remove currently unused `electron-rebuild`
  • remove `pre-commit` from package.json as its logic is now bundled into `mongodb-js-precommit`
  • refactor: Collapse lodash dependency

Move away from `lodash.*` to top-level `lodash` that is far easier to maintain.

  • chore: Allow mongodb-security semver to update automatically
  • chore: connection-model update for kerberos electron 6 fix

mongodb-js/connection-model#210

  • fix(test): No idea how this test ever actually passed before... :white_check_mark:
  • feat(ci): Default test is now electron renderer

So we can catch mismatched behaviors in the future as NODE-2387 uncovered

  • chore: update mongodb-runner mongodb-js/runner#158
Comment by Githook User [ 06/Jan/20 ]

Author:

{'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com', 'username': 'imlucas'}

Message: Merge branch 'master' into COMPASS-3933
Branch: COMPASS-3933
https://github.com/mongodb-js/compass/commit/9a14c14f7f10647465ce130b69fce99654c9eead

Comment by Githook User [ 17/Dec/19 ]

Author:

{'name': 'Durran Jordan', 'email': 'durran@gmail.com', 'username': 'durran'}

Message: COMPASS-3933: Update to Electron 6.0.11
Branch: COMPASS-3933
https://github.com/mongodb-js/compass/commit/a7bcd7d77c7cf2c3efb7a52a072b17d4f9d2814b

Comment by Lucas Hrabovsky (Inactive) [ 16/Dec/19 ]

We need to migrate off mongodb-extjson to bson.EJSON but bson.EJSON only supports ejson v2. To avoid updating query history and everything else that uses legacy ejson, we'll do NODE-2253 then switch out our usage of mongodb-extjson for bson.EJSON legacy.

Generated at Wed Feb 07 22:34:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.