[COMPASS-3933] Update to Electron 6 Created: 16/Oct/19 Updated: 29/Oct/23 Resolved: 29/Jan/20 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.21.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Durran Jordan | Assignee: | Lucas Hrabovsky (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||
| Sprint: | Iteration Python, Iteration Tarantula, Iteration Ragamuffin, Iteration Snake, Iteration Urial, Iteration Vicuña | ||||||||||||||||||||||||||||
| Description |
|
Update to Electron 6 with latest Keytar. |
| Comments |
| Comment by Githook User [ 03/Feb/20 ] |
|
Author: {'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}Message: build: Evergreen:
Rollback `electron-winstaller` to `2.5.1` for now. Don't upgrade until [BUILD-2932](https://jira.mongodb.org/browse/BUILD-2932) is done.
[Evergreen windows builds](https://evergreen.mongodb.com/task/10gen_compass_master_windows_package_and_publish_compass_3d7b0895c3d7ed4aada6f997286a8a57d7f835b5_20_01_31_17_33_22) started failing with the electron 6 update: ``` Normally, `Failed with exit code: 4294967295` means [the signtool.exe notary service client](https://jira.mongodb.org/browse/BUILD-920) is getting a 500 service error due to an outage. However, all other OS were signing with no issues [see BUILD-10250](https://jira.mongodb.org/browse/BUILD-10250). ``` $ ../../signtool.exe sign yes ffmpeg.dll $ ../../signtool.exe sign yes libEGL.dll $ ../../signtool.exe sign yes MongoDBCompassDev.exe So, it can't be a service issue and must be something related to the changes to `hadron-build` for Only a handful of commits and [e3ff85c9303bc43e56976226d10d6b9897324b66](https://github.com/mongodb-js/hadron-build/commit/e3ff85c9303bc43e56976226d10d6b9897324b66)
In `electron-winstaller@2.5.2` :arrow_right: [squirrel.windows@1.5.2](https://github.com/Squirrel/Squirrel.Windows/releases/tag/1.5.2): > ### Releasify now disallows non-Semver versions And now the facepalm moment; [BUILD-2932](https://jira.mongodb.org/browse/BUILD-2932) (created in 2017) as the notary service doesn't support dll signing the way we need it to.
mongodb-js/hadron-build#110
|
| Comment by Githook User [ 29/Jan/20 ] |
|
Author: {'username': 'durran', 'name': 'Durran Jordan', 'email': 'durran@gmail.com'}Message:
Switched to prettier ages ago
hadron-app@latest hadron-app-registry@latest hadron-compile-cache@latest hadron-document@latest hadron-module-cache@latest
Co-authored-by: Lucas Hrabovsky <hrabovsky.lucas@gmail.com> |
| Comment by Githook User [ 29/Jan/20 ] |
|
Author: {'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}Message: Merge branch 'master' into |
| Comment by Githook User [ 29/Jan/20 ] |
|
Author: {'username': 'imlucas', 'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com'}Message: |
| Comment by Githook User [ 28/Jan/20 ] |
|
Author: {'email': 'hrabovsky.lucas@gmail.com', 'name': 'Lucas Hrabovsky', 'username': 'imlucas'}Message: |
| Comment by Githook User [ 27/Jan/20 ] |
|
Author: {'username': 'imlucas', 'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com'}Message: |
| Comment by Githook User [ 22/Jan/20 ] |
|
Author: {'username': 'imlucas', 'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com'}Message: Merge branch 'master' into |
| Comment by Githook User [ 22/Jan/20 ] |
|
Author: {'username': 'imlucas', 'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com'}Message: build(deps):
|
| Comment by Githook User [ 22/Jan/20 ] |
|
Author: {'email': 'hrabovsky.lucas@gmail.com', 'username': 'imlucas', 'name': 'Lucas Hrabovsky'}Message: build(deps):
|
| Comment by Githook User [ 15/Jan/20 ] |
|
Author: {'name': 'dependabot-preview[bot]', 'email': '27856297+dependabot-preview[bot]@users.noreply.github.com', 'username': 'dependabot-preview[bot]'}Message: fix(deps): Bumps [bson](https://github.com/mongodb/js-bson) from 4.0.1 to 4.0.3.
Signed-off-by: dependabot-preview[bot] <support@dependabot.com> |
| Comment by Githook User [ 15/Jan/20 ] |
|
Author: {'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com', 'username': 'imlucas'}Message: Merge branch 'master' into |
| Comment by Githook User [ 06/Jan/20 ] |
|
Author: {'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com', 'username': 'imlucas'}Message: feat:
Move away from `lodash.*` to top-level `lodash` that is far easier to maintain.
mongodb-js/connection-model#210
So we can catch mismatched behaviors in the future as
|
| Comment by Githook User [ 06/Jan/20 ] |
|
Author: {'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com', 'username': 'imlucas'}Message: Merge branch 'master' into |
| Comment by Githook User [ 17/Dec/19 ] |
|
Author: {'name': 'Durran Jordan', 'email': 'durran@gmail.com', 'username': 'durran'}Message: |
| Comment by Lucas Hrabovsky (Inactive) [ 16/Dec/19 ] |
|
We need to migrate off mongodb-extjson to bson.EJSON but bson.EJSON only supports ejson v2. To avoid updating query history and everything else that uses legacy ejson, we'll do |