[COMPASS-3943] Update to node driver 3.3.4 Created: 28/Oct/19 Updated: 29/Oct/23 Resolved: 13/Nov/19 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | Connectivity |
| Affects Version/s: | None |
| Fix Version/s: | 1.20.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Lucas Hrabovsky (Inactive) | Assignee: | Lucas Hrabovsky (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Sprint: | Iteration Ragamuffin | ||||||||||||||||
| Description |
|
This should help with issues such as Few issues to sort for 3.3.3 identified already: https://github.com/mongodb-js/data-service/pull/154 and https://github.com/mongodb-js/compass/pull/1834 |
| Comments |
| Comment by Githook User [ 13/Nov/19 ] |
|
Author: {'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com', 'name': 'Lucas Hrabovsky'}Message: |
| Comment by Githook User [ 13/Nov/19 ] |
|
Author: {'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}Message:
https://github.com/mongodb-js/data-service/pull/154
Instead use equivalent `require('mongodb').ReadPreference` |
| Comment by Githook User [ 13/Nov/19 ] |
|
Author: {'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com', 'name': 'Lucas Hrabovsky'}Message:
https://github.com/mongodb-js/data-service/pull/154
Instead use equivalent `require('mongodb').ReadPreference` |
| Comment by Githook User [ 13/Nov/19 ] |
|
Author: {'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com', 'name': 'Lucas Hrabovsky'}Message:
https://github.com/mongodb-js/data-service/pull/154
Instead use equivalent `require('mongodb').ReadPreference` |
| Comment by Githook User [ 12/Nov/19 ] |
|
Author: {'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}Message:
These were breaking on update because of info leakage from driver. 1. Connectivity is tested with `mongodb-connection-model#test()` not via a connect() call because a test should use different timeout values than a connection which will be used more than once. In the case of this test, the selection timeout in the driver is 30000ms which caused this test to fail with `exceeded test timout of 2000`. 2. Retryable reads and writes are now supported by the driver which invalidates the state the disconnect() test relied upon, resulting in a `Topology Destroyed` errror for subsequent calls to the client once closed. Like #1 above, after 30000ms, the `count()` would eventually error but full disconnect() behavior is tested in many other code paths. |
| Comment by Githook User [ 12/Nov/19 ] |
|
Author: {'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}Message: |