[COMPASS-3943] Update to node driver 3.3.4 Created: 28/Oct/19  Updated: 29/Oct/23  Resolved: 13/Nov/19

Status: Closed
Project: Compass
Component/s: Connectivity
Affects Version/s: None
Fix Version/s: 1.20.0

Type: Task Priority: Major - P3
Reporter: Lucas Hrabovsky (Inactive) Assignee: Lucas Hrabovsky (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by COMPASS-3849 Compass loses connection after a while Closed
Related
is related to COMPASS-3728 Top in performance tab times out when... Closed
Sprint: Iteration Ragamuffin

 Description   

This should help with issues such as COMPASS-3849 per discussion in Slack.

Few issues to sort for 3.3.3 identified already: https://github.com/mongodb-js/data-service/pull/154 and https://github.com/mongodb-js/compass/pull/1834



 Comments   
Comment by Githook User [ 13/Nov/19 ]

Author:

{'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com', 'name': 'Lucas Hrabovsky'}

Message: COMPASS-3943: Update to mongodb@3.3.4
Branch: COMPASS-3963
https://github.com/mongodb-js/compass/commit/0ea3f5ff1730d25337b43c0a3c92c42faf0ac2ea

Comment by Githook User [ 13/Nov/19 ]

Author:

{'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}

Message: COMPASS-3943: Update to latest node driver 3.3.4 (#1834)

  • chore: update to node driver@3.3.3
  • chore: remove extraneous mongodb-core dependency
  • chore: update to `mongodb-data-service@15.4.0`

https://github.com/mongodb-js/data-service/pull/154

  • fix: Deprecate usage of mongodb-core

Instead use equivalent `require('mongodb').ReadPreference`
Branch: 1.20-releases
https://github.com/mongodb-js/compass/commit/c8ac35fffb7d498022ba8ec49dcf8f278a0bf569

Comment by Githook User [ 13/Nov/19 ]

Author:

{'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com', 'name': 'Lucas Hrabovsky'}

Message: COMPASS-3943: Update to latest node driver 3.3.4 (#1834)

  • chore: update to node driver@3.3.3
  • chore: remove extraneous mongodb-core dependency
  • chore: update to `mongodb-data-service@15.4.0`

https://github.com/mongodb-js/data-service/pull/154

  • fix: Deprecate usage of mongodb-core

Instead use equivalent `require('mongodb').ReadPreference`
Branch: backport/COMPASS-3943
https://github.com/mongodb-js/compass/commit/7efe62119b2168021002e265b1b21296fa9e1815

Comment by Githook User [ 13/Nov/19 ]

Author:

{'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com', 'name': 'Lucas Hrabovsky'}

Message: COMPASS-3943: Update to latest node driver 3.3.4 (#1834)

  • chore: update to node driver@3.3.3
  • chore: remove extraneous mongodb-core dependency
  • chore: update to `mongodb-data-service@15.4.0`

https://github.com/mongodb-js/data-service/pull/154

  • fix: Deprecate usage of mongodb-core

Instead use equivalent `require('mongodb').ReadPreference`
Branch: master
https://github.com/mongodb-js/compass/commit/3125a2cd1677265a4e27ad26a5b72201a3f721d1

Comment by Githook User [ 12/Nov/19 ]

Author:

{'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}

Message: COMPASS-3943: Update to latest node driver 3.3.4 (#154)

  • chore: update to `mongodb@3.3.3`
  • chore: remove extraneous mongodb-core dependency
  • driver: Update to mongodb@3.3.4
  • fix: remove old smoke tests

These were breaking on update because of info leakage from driver.

1. Connectivity is tested with `mongodb-connection-model#test()` not via a connect() call because a test should use different timeout values than a connection which will be used more than once. In the case of this test, the selection timeout in the driver is 30000ms which caused this test to fail with `exceeded test timout of 2000`.

2. Retryable reads and writes are now supported by the driver which invalidates the state the disconnect() test relied upon, resulting in a `Topology Destroyed` errror for subsequent calls to the client once closed. Like #1 above, after 30000ms, the `count()` would eventually error but full disconnect() behavior is tested in many other code paths.
Branch: master
https://github.com/mongodb-js/data-service/commit/6d00ad75f01a77c0eacea09a0ca5432a5c7996e7

Comment by Githook User [ 12/Nov/19 ]

Author:

{'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}

Message: COMPASS-3943: Update to mongodb@3.3.4
Branch: update-driver
https://github.com/mongodb-js/compass/commit/0ea3f5ff1730d25337b43c0a3c92c42faf0ac2ea

Generated at Wed Feb 07 22:34:45 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.