[COMPASS-4191] Resolve trie.js dependency Created: 04/Mar/20  Updated: 29/Oct/23  Resolved: 04/Mar/20

Status: Closed
Project: Compass
Component/s: None
Affects Version/s: None
Fix Version/s: 1.21.0

Type: Task Priority: Major - P3
Reporter: Lucas Hrabovsky (Inactive) Assignee: Lucas Hrabovsky (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: COMPASS-3417

 Description   

vscode npm run package fails like so:
https://dev.azure.com/team-compass/vscode/_build/results?buildId=746&view=logs&j=291b3e6c-60a9-5f30-6b17-b27c7388dcd0&t=73e02479-b06a-558b-66de-a6177ecb9da0&l=63

 ERROR  Command failed: npm list --production --parseable --depth=99999 --loglevel=error
npm ERR! missing: triejs@github:rueckstiess/triejs, required by mongodb-index-model@2.5.0

The changes to triejs are minimal https://github.com/pthurlow/triejs/compare/master...rueckstiess:master so lets publish an @mongodb-js/triejs or something.



 Comments   
Comment by Githook User [ 04/Mar/20 ]

Author:

{'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}

Message: chore: COMPASS-4191: Elliminate triejs as a git:// dependency (#1912)

```
mongodb ^3.5.2 → ^3.5.4
mongodb-data-service ^16.5.5 → ^16.5.6
mongodb-index-model ^2.5.0 → ^2.6.0
```

https://github.com/mongodb-js/index-model/pull/62
https://github.com/mongodb-js/data-service/pull/204
Branch: master
https://github.com/mongodb-js/compass/commit/192d2d40bb8d624b553d4fa5c593f4e6172e3a75

Comment by Githook User [ 04/Mar/20 ]

Author:

{'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}

Message: chore: COMPASS-4191: Elliminate triejs as a git:// dependency

```
mongodb ^3.5.2 → ^3.5.4
mongodb-data-service ^16.5.5 → ^16.5.6
mongodb-index-model ^2.5.0 → ^2.6.0
```

https://github.com/mongodb-js/index-model/pull/62
https://github.com/mongodb-js/data-service/pull/204
Branch: update-triejs
https://github.com/mongodb-js/compass/commit/2fe13db7971c06da6af2f71641124fd8e8910cb0

Comment by Githook User [ 04/Mar/20 ]

Author:

{'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}

Message: chore: COMPASS-4191: Update deps (#204)

```
[update-deps] data-service/ ncu -u async lodash mongodb mongodb-collection-sample mongodb-index-model mongodb-ns chai electron-mocha electron-rebuild mocha mongodb-js-precommit
Upgrading /Users/lucas/data-service/package.json
[====================] 11/11 100%

async ^3.1.0 → ^3.2.0
lodash ^4.17.0 → ^4.17.15
mongodb ^3.5.2 → ^3.5.4
mongodb-collection-sample ^4.4.4 → ^4.5.1
mongodb-index-model ^2.5.0 → ^2.6.0
mongodb-ns ^2.0.0 → ^2.2.0
chai ^3.4.1 → ^4.2.0
electron-mocha ^8.1.2 → ^8.2.1
electron-rebuild ^1.8.8 → ^1.10.0
mocha ^7.0.0 → ^7.1.0
mongodb-js-precommit ^2.0.0 → ^2.2.1
```

  • fix: `.property()` in `chai@4` upgrade

In chai@3:

```
expect(indexes).to.not.have.property(

{ name: 'a_1' }

);
```

In chai@4:

```
expect(indexes).to.not.have.property('name', 'a_1');
```
Branch: master
https://github.com/mongodb-js/data-service/commit/0bc15f58566eeb5ed6e265d91972e5f7d5c4ec16

Comment by Githook User [ 04/Mar/20 ]

Author:

{'username': 'imlucas', 'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com'}

Message: chore: COMPASS-4191: Update deps

```
[update-deps] data-service/ ncu -u async lodash mongodb mongodb-collection-sample mongodb-index-model mongodb-ns chai electron-mocha electron-rebuild mocha mongodb-js-precommit
Upgrading /Users/lucas/data-service/package.json
[====================] 11/11 100%

async ^3.1.0 → ^3.2.0
lodash ^4.17.0 → ^4.17.15
mongodb ^3.5.2 → ^3.5.4
mongodb-collection-sample ^4.4.4 → ^4.5.1
mongodb-index-model ^2.5.0 → ^2.6.0
mongodb-ns ^2.0.0 → ^2.2.0
chai ^3.4.1 → ^4.2.0
electron-mocha ^8.1.2 → ^8.2.1
electron-rebuild ^1.8.8 → ^1.10.0
mocha ^7.0.0 → ^7.1.0
mongodb-js-precommit ^2.0.0 → ^2.2.1
```
Branch: update-deps
https://github.com/mongodb-js/data-service/commit/42c1fb8c54947007b22a535a20a7cd42a16335c1

Comment by Githook User [ 04/Mar/20 ]

Author:

{'username': 'imlucas', 'name': 'Lucas Hrabovsky', 'email': 'hrabovsky.lucas@gmail.com'}

Message: chore(deps): COMPASS-4191: Switch to namespaced fork of triejs on npm (#62)

COMPASS-4191(https://jira.mongodb.org/browse/COMPASS-4191) notes:

> vscode `npm run package` fails like so:
https://dev.azure.com/team-compass/vscode/_build/results?buildId=746&view=logs&j=291b3e6c-60a9-5f30-6b17-b27c7388dcd0&t=73e02479-b06a-558b-66de-a6177ecb9da0&l=63
>
> ```
> ERROR Command failed: npm list --production --parseable --depth=99999 --loglevel=error
> npm ERR! missing: triejs@github:rueckstiess/triejs, required by mongodb-index-model@2.5.0
> ```

The [changes to triejs are minimal](https://github.com/pthurlow/triejs/compare/master...rueckstiess:master) in the fork so I made [`@mongodb-js/triejs`](https://npm.im/@mongodb-js/triejs) to remove the `git://` dep complexity from our build toolchain.

While I'm in here, I've also done dependency updates, fixed tests, and added additional debugging for Compass' sake.

  • chore: Update dependencies

```
[triejs] index-model/ ncu -u async lodash mongodb mongodb-js-errors mongodb-ns debug eslint-config-mongodb-js mocha mongodb-js-precommit mongodb-runner;
npm i;Upgrading /Users/lucas/index-model/package.json
[====================] 10/10 100%

async ^1.5.2 → ^3.2.0
lodash ^4.8.2 → ^4.17.15
mongodb ^3.1.9 → ^3.5.4
mongodb-js-errors ^0.4.0 → ^0.5.0
mongodb-ns ^2.0.0 → ^2.2.0
debug ^2.2.0 → ^4.1.1
eslint-config-mongodb-js ^3.0.1 → ^5.0.3
mocha ^5.2.0 → ^7.1.0
mongodb-js-precommit ^2.0.0 → ^2.2.1
mongodb-runner ^4.7.1 → ^4.8.0
```

  • chore: Fixes for dependency updates
Comment by Githook User [ 04/Mar/20 ]

Author:

{'name': 'Lucas Hrabovsky', 'username': 'imlucas', 'email': 'hrabovsky.lucas@gmail.com'}

Message: chore(deps): COMPASS-4191: Switch to namespaced fork of triejs on npm
Branch: triejs
https://github.com/mongodb-js/index-model/commit/095846b9dfa6fc69f05789798544a0ae50619283

Generated at Wed Feb 07 22:35:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.