[COMPASS-4528] Upgrade compass-aggregations to react-ace@9.5.0 Created: 07/Dec/20  Updated: 09/Aug/22  Resolved: 01/Dec/21

Status: Closed
Project: Compass
Component/s: Compass
Affects Version/s: None
Fix Version/s: 1.31.0

Type: Story Priority: Major - P3
Reporter: Jack Weir Assignee: Le Roux Bodenstein
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to COMPASS-5764 Aggregations preview document renderi... Closed
related to COMPASS-5369 Upgrade compass-aggregations to react... Closed
related to COMPASS-5328 Manage react-ace as a peerDep Closed
is related to COMPASS-4721 Can't input korean language to "Inser... Closed
Story Points: 3
Documentation Changes: Not Needed
Sprint: Iteration Orlando, Iteration Phnom Penh, Iteration Q

 Description   

Problem Description

As part of the 3rd Party HIPPA upgrades for mms, we've upgraded to using the newest (9.2.0 9.4.3) version of react-ace. Because @mongodb-js/compass-aggregations has a peer dependency on the old react-ace version, it will also need to be modified to use the latest react-ace version, which does have some breaking changes.

I've attempted to do the upgrade myself but consistently hit the following (annoyingly minified) error when attempting to render the AggregationsPlugin in mms. If someone with more familiarity with the library could complete and QA this react-ace upgrade, it would unblock our mms upgrade

index.js:22 Uncaught (in promise) TypeError: Cannot read property 'shape' of undefined
    at Module.<anonymous> (index.js:22)
    at n (index.js:1)
    at index.js:1
    at index.js:1
    at index.js:1
    at Module.<anonymous> (index.js:1)
    at Module.../../../compass-aggregations/lib/index.js (index.js:27)
    at __webpack_require__ (bootstrap:63)
    at Module../project/metrics/components/DataExplorerAggregation.js (index.js:27)
    at __webpack_require__ (bootstrap:63)

Steps to Reproduce

Expected Results

Actual Results

Additional Notes



 Comments   
Comment by Githook User [ 07/Dec/21 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(deps): upgrade react-ace to 9.5.0 COMPASS-4528 (#2603)
Branch: subprocess-exec
https://github.com/mongodb-js/compass/commit/e1dfbd07028500875a20e1e25810479edce86c24

Comment by Githook User [ 03/Dec/21 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(deps): upgrade react-ace to 9.5.0 COMPASS-4528 (#2603)
Branch: COMPASS-5231-add-general-tab-contents-to-connect-form
https://github.com/mongodb-js/compass/commit/e1dfbd07028500875a20e1e25810479edce86c24

Comment by Githook User [ 03/Dec/21 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(deps): upgrade react-ace to 9.5.0 COMPASS-4528 (#2603)
Branch: 1.29-releases
https://github.com/mongodb-js/compass/commit/e1dfbd07028500875a20e1e25810479edce86c24

Comment by Githook User [ 02/Dec/21 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(deps): upgrade react-ace to 9.5.0 COMPASS-4528 (#2603)
Branch: COMPASS-5270-connection-list-styling
https://github.com/mongodb-js/compass/commit/e1dfbd07028500875a20e1e25810479edce86c24

Comment by Githook User [ 01/Dec/21 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(deps): upgrade react-ace to 9.5.0 COMPASS-4528 (#2603)
Branch: main
https://github.com/mongodb-js/compass/commit/e1dfbd07028500875a20e1e25810479edce86c24

Comment by Githook User [ 30/Nov/21 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore: no need for webpack-resolver, set useWorker: false COMPASS-4528 (#1163)
Branch: main
https://github.com/mongodb-js/mongosh/commit/c39d5f844e74b596ca20ebd292fd2c7a02f7417e

Comment by Githook User [ 29/Nov/21 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: Revert "chore(deps): upgrade react-ace to 9.5.0 COMPASS-4528 (#1157)"

This reverts commit b1ab401e04fba998b4d86001573814b5e92c23eb.
Branch: revert-update-react-ace
https://github.com/mongodb-js/mongosh/commit/7d248c4465c2aff5387c11f823e49d95106e6307

Comment by Githook User [ 19/Nov/21 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(deps): upgrade react-ace to 9.5.0 COMPASS-4528 (#1157)

  • Upgrade react-ace to 9.5.0
  • fix autocompletion
  • fix type casting
  • shuffle some imports
  • fix the theme
  • Update packages/browser-repl/src/components/editor.tsx

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • delete window.prompt from the iframe

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: main
https://github.com/mongodb-js/mongosh/commit/b1ab401e04fba998b4d86001573814b5e92c23eb

Generated at Wed Feb 07 22:36:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.