[COMPASS-4550] Remove `connection-model` port validation Created: 04/Jan/21 Updated: 29/Oct/23 Resolved: 08/Jan/21 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | Connectivity |
| Affects Version/s: | None |
| Fix Version/s: | 1.25.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Rhys Howell | Assignee: | Anna Henningsen |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | COMPASS-4362 | ||||||||
| Story Points: | 3 | ||||||||
| Documentation Changes: | Not Needed | ||||||||
| Sprint: | Iteration Tangerine | ||||||||
| Description |
|
We should update the port input to be an html `number` field. In connection model we can remove the port validation: https://github.com/mongodb-js/connection-model/blob/master/lib/data-types.js#L18 this error is not properly caught and is one of our larger bugsnag reports: [https://app.bugsnag.com/mongodb/mongodb-compass/errors/5975fdd000f9a600199afc7a?filters[event.since][0]=30d&filters[error.status][0]=open] |
| Comments |
| Comment by Githook User [ 08/Jan/21 ] |
|
Author: {'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}Message: chore!: remove datatype validation code |