|
Author:
{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}
Message: fix(explain-plan): migrate to TS/away from Ampersand, fix sharding warning bug (#2494)
- chore(explain-plan): drop serverVersion from state
This does not have any actual impact on the UI.
- feat(explain-plan): replace explain-plan ampersand model
Replace the explain-plan-model Ampersand model and replace
it with a typescript helper package.
This new package matches the model broadly, except in a
few aspects:
- It automatically includes the SBE compatibiltiy helper,
removing the need to apply it explicitly in compass-explain-plan.
- The “raw” original data property is exposed directly, not
attached via monkey-patching in compass-explain-plan.
- `model.serialize()` is gone, the compass-explain-plan
package now manually unpacks the properties it uses.
This may not look very pretty, but at least it doesn’t
hide the fact that we are using the object as an untyped
bag of properties anymore.
- The child stage iterator helper is exposed, allowing some
code redundancy between the packages to be removed.
- Support for pre-3.0 server explain plans is dropped.
- chore(explain-plan): replace usedIndex field to make it more meaningful
Replace the `usedIndex` field, which had an odd typing to begin
with, with a `usedIndexes` field that reflects all indices used
and what shards they were used on in a consistent way that matches
its actual usage.
- fix(explain-plan): do not display shard warning when inappropriate
COMPASS-4770
This warning is supposed to tell people about situations in which
different shards used difference indices in their explain plan,
which is fine to warn about.
However, the check was fairly naïve and only warned whether multiple
indices were used at all. That can lead to false positives, since
using multiple indices by itself is not problematic.
Address this by grouping the used indices by the shards they were
run on, and seeing if these structures actually differ between
the individual shards.
Branch: compass-5113-remove-loading-screen-from-the-app
https://github.com/mongodb-js/compass/commit/5f78690e663bd94bfbb4a1bb26398fae5fa1a73a
|
|
Author:
{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}
Message: fix(explain-plan): migrate to TS/away from Ampersand, fix sharding warning bug (#2494)
- chore(explain-plan): drop serverVersion from state
This does not have any actual impact on the UI.
- feat(explain-plan): replace explain-plan ampersand model
Replace the explain-plan-model Ampersand model and replace
it with a typescript helper package.
This new package matches the model broadly, except in a
few aspects:
- It automatically includes the SBE compatibiltiy helper,
removing the need to apply it explicitly in compass-explain-plan.
- The “raw” original data property is exposed directly, not
attached via monkey-patching in compass-explain-plan.
- `model.serialize()` is gone, the compass-explain-plan
package now manually unpacks the properties it uses.
This may not look very pretty, but at least it doesn’t
hide the fact that we are using the object as an untyped
bag of properties anymore.
- The child stage iterator helper is exposed, allowing some
code redundancy between the packages to be removed.
- Support for pre-3.0 server explain plans is dropped.
- chore(explain-plan): replace usedIndex field to make it more meaningful
Replace the `usedIndex` field, which had an odd typing to begin
with, with a `usedIndexes` field that reflects all indices used
and what shards they were used on in a consistent way that matches
its actual usage.
- fix(explain-plan): do not display shard warning when inappropriate
COMPASS-4770
This warning is supposed to tell people about situations in which
different shards used difference indices in their explain plan,
which is fine to warn about.
However, the check was fairly naïve and only warned whether multiple
indices were used at all. That can lead to false positives, since
using multiple indices by itself is not problematic.
Address this by grouping the used indices by the shards they were
run on, and seeing if these structures actually differ between
the individual shards.
Branch: COMPASS-5053-loading-status
https://github.com/mongodb-js/compass/commit/5f78690e663bd94bfbb4a1bb26398fae5fa1a73a
|
|
Author:
{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}
Message: fix(explain-plan): migrate to TS/away from Ampersand, fix sharding warning bug (#2494)
- chore(explain-plan): drop serverVersion from state
This does not have any actual impact on the UI.
- feat(explain-plan): replace explain-plan ampersand model
Replace the explain-plan-model Ampersand model and replace
it with a typescript helper package.
This new package matches the model broadly, except in a
few aspects:
- It automatically includes the SBE compatibiltiy helper,
removing the need to apply it explicitly in compass-explain-plan.
- The “raw” original data property is exposed directly, not
attached via monkey-patching in compass-explain-plan.
- `model.serialize()` is gone, the compass-explain-plan
package now manually unpacks the properties it uses.
This may not look very pretty, but at least it doesn’t
hide the fact that we are using the object as an untyped
bag of properties anymore.
- The child stage iterator helper is exposed, allowing some
code redundancy between the packages to be removed.
- Support for pre-3.0 server explain plans is dropped.
- chore(explain-plan): replace usedIndex field to make it more meaningful
Replace the `usedIndex` field, which had an odd typing to begin
with, with a `usedIndexes` field that reflects all indices used
and what shards they were used on in a consistent way that matches
its actual usage.
- fix(explain-plan): do not display shard warning when inappropriate
COMPASS-4770
This warning is supposed to tell people about situations in which
different shards used difference indices in their explain plan,
which is fine to warn about.
However, the check was fairly naïve and only warned whether multiple
indices were used at all. That can lead to false positives, since
using multiple indices by itself is not problematic.
Address this by grouping the used indices by the shards they were
run on, and seeing if these structures actually differ between
the individual shards.
Branch: compass-home-ts
https://github.com/mongodb-js/compass/commit/5f78690e663bd94bfbb4a1bb26398fae5fa1a73a
|
|
Author:
{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}
Message: fix(explain-plan): migrate to TS/away from Ampersand, fix sharding warning bug (#2494)
- chore(explain-plan): drop serverVersion from state
This does not have any actual impact on the UI.
- feat(explain-plan): replace explain-plan ampersand model
Replace the explain-plan-model Ampersand model and replace
it with a typescript helper package.
This new package matches the model broadly, except in a
few aspects:
- It automatically includes the SBE compatibiltiy helper,
removing the need to apply it explicitly in compass-explain-plan.
- The “raw” original data property is exposed directly, not
attached via monkey-patching in compass-explain-plan.
- `model.serialize()` is gone, the compass-explain-plan
package now manually unpacks the properties it uses.
This may not look very pretty, but at least it doesn’t
hide the fact that we are using the object as an untyped
bag of properties anymore.
- The child stage iterator helper is exposed, allowing some
code redundancy between the packages to be removed.
- Support for pre-3.0 server explain plans is dropped.
- chore(explain-plan): replace usedIndex field to make it more meaningful
Replace the `usedIndex` field, which had an odd typing to begin
with, with a `usedIndexes` field that reflects all indices used
and what shards they were used on in a consistent way that matches
its actual usage.
- fix(explain-plan): do not display shard warning when inappropriate
COMPASS-4770
This warning is supposed to tell people about situations in which
different shards used difference indices in their explain plan,
which is fine to warn about.
However, the check was fairly naïve and only warned whether multiple
indices were used at all. That can lead to false positives, since
using multiple indices by itself is not problematic.
Address this by grouping the used indices by the shards they were
run on, and seeing if these structures actually differ between
the individual shards.
Branch: electron-13-same-keytar-node-14
https://github.com/mongodb-js/compass/commit/5f78690e663bd94bfbb4a1bb26398fae5fa1a73a
|
|
Author:
{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}
Message: fix(explain-plan): migrate to TS/away from Ampersand, fix sharding warning bug (#2494)
- chore(explain-plan): drop serverVersion from state
This does not have any actual impact on the UI.
- feat(explain-plan): replace explain-plan ampersand model
Replace the explain-plan-model Ampersand model and replace
it with a typescript helper package.
This new package matches the model broadly, except in a
few aspects:
- It automatically includes the SBE compatibiltiy helper,
removing the need to apply it explicitly in compass-explain-plan.
- The “raw” original data property is exposed directly, not
attached via monkey-patching in compass-explain-plan.
- `model.serialize()` is gone, the compass-explain-plan
package now manually unpacks the properties it uses.
This may not look very pretty, but at least it doesn’t
hide the fact that we are using the object as an untyped
bag of properties anymore.
- The child stage iterator helper is exposed, allowing some
code redundancy between the packages to be removed.
- Support for pre-3.0 server explain plans is dropped.
- chore(explain-plan): replace usedIndex field to make it more meaningful
Replace the `usedIndex` field, which had an odd typing to begin
with, with a `usedIndexes` field that reflects all indices used
and what shards they were used on in a consistent way that matches
its actual usage.
- fix(explain-plan): do not display shard warning when inappropriate
COMPASS-4770
This warning is supposed to tell people about situations in which
different shards used difference indices in their explain plan,
which is fine to warn about.
However, the check was fairly naïve and only warned whether multiple
indices were used at all. That can lead to false positives, since
using multiple indices by itself is not problematic.
Address this by grouping the used indices by the shards they were
run on, and seeing if these structures actually differ between
the individual shards.
Branch: main
https://github.com/mongodb-js/compass/commit/5f78690e663bd94bfbb4a1bb26398fae5fa1a73a
|
|
Author:
{'name': 'Anna Henningsen', 'email': 'anna@addaleax.net', 'username': 'addaleax'}
Message: fix(explain-plan): do not display shard warning when inappropriate COMPASS-4770
This warning is supposed to tell people about situations in which
different shards used difference indices in their explain plan,
which is fine to warn about.
However, the check was fairly naïve and only warned whether multiple
indices were used at all. That can lead to false positives, since
using multiple indices by itself is not problematic.
Address this by grouping the used indices by the shards they were
run on, and seeing if these structures actually differ between
the individual shards.
Branch: 4770-dev
https://github.com/mongodb-js/compass/commit/8513af412931a82809f78e3d7ba136259555ab9d
|
|
Author:
{'name': 'Anna Henningsen', 'email': 'anna@addaleax.net', 'username': 'addaleax'}
Message: fix(explain-plan): do not display shard warning when inappropriate COMPASS-4770
This warning is supposed to tell people about situations in which
different shards used difference indices in their explain plan,
which is fine to warn about.
However, the check was fairly naïve and only warned whether multiple
indices were used at all. That can lead to false positives, since
using multiple indices by itself is not problematic.
Address this by grouping the used indices by the shards they were
run on, and seeing if these structures actually differ between
the individual shards.
Branch: 4770-dev
https://github.com/mongodb-js/compass/commit/25e73bc6d44eb2294586f13afd5e1b6d4067ff50
|
|
Author:
{'name': 'Anna Henningsen', 'email': 'anna@addaleax.net', 'username': 'addaleax'}
Message: fix(explain-plan): do not display shard warning when inappropriate COMPASS-4770
This warning is supposed to tell people about situations in which
different shards used difference indices in their explain plan,
which is fine to warn about.
However, the check was fairly naïve and only warned whether multiple
indices were used at all. That can lead to false positives, since
using multiple indices by itself is not problematic.
Address this by grouping the used indices by the shards they were
run on, and seeing if these structures actually differ between
the individual shards.
Branch: 4770-dev
https://github.com/mongodb-js/compass/commit/535e918ad5de1cb358aa4d97908e9e32b7b09908
|
|
Author:
{'name': 'Anna Henningsen', 'email': 'anna@addaleax.net', 'username': 'addaleax'}
Message: fix(explain-plan): do not display shard warning when inappropriate COMPASS-4770
This warning is supposed to tell people about situations in which
different shards used difference indices in their explain plan,
which is fine to warn about.
However, the check was fairly naïve and only warned whether multiple
indices were used at all. That can lead to false positives, since
using multiple indices by itself is not problematic.
Address this by grouping the used indices by the shards they were
run on, and seeing if these structures actually differ between
the individual shards.
Branch: 4770-dev
https://github.com/mongodb-js/compass/commit/745915cd8d2e5f235ed1f90ad203a268425cfc7a
|
Generated at Wed Feb 07 22:37:24 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.