[COMPASS-5075] Add react error boundaries to `connect` Created: 08/Sep/21 Updated: 10/Jan/24 Resolved: 28/Jan/22 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | Connectivity, Tech debt |
| Affects Version/s: | None |
| Fix Version/s: | 1.31.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Rhys Howell | Assignee: | Rhys Howell |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Epic Link: | COMPASS-4948 | ||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||
| Documentation Changes: | Not Needed | ||||||||||||||||||||
| Sprint: | Iteration Seoul, Iteration Tokyo | ||||||||||||||||||||
| Description |
|
Currently we only have react error boundaries set up for the various tabs in compass (databases, collections, collection views). We should add error boundaries to the rendering of parts of the connection form as well. It will help gracefully handle errors that occur when the component is rendered. This should ideally should never happen, but in the case that it does happen, a user should be able to see the error that occurred without opening the console, and possibly use other parts of Compass that are unaffected since the error no longer breaks the react window instance (with the connect form this would mean they could choose a non-erroring connection and continue using compass). React error boundaries: Here's an example of how we currently handle them in Compass: We should update UnsafeComponent to use the current recommended react implementation: |
| Comments |
| Comment by Githook User [ 04/Feb/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: chore(connections): Add react error boundary to compass-components and wrap new connect form |
| Comment by Githook User [ 01/Feb/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: chore(connections): Add react error boundary to compass-components and wrap new connect form |
| Comment by Githook User [ 31/Jan/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: chore(connections): Add react error boundary to compass-components and wrap new connect form |
| Comment by Githook User [ 28/Jan/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: chore(connections): Add react error boundary to compass-components and wrap new connect form |