[COMPASS-5207] Refactor dataService.instance method to simplify the data fetching code flow Created: 20/Oct/21 Updated: 29/Oct/23 Resolved: 02/Nov/21 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | Data Service |
| Affects Version/s: | None |
| Fix Version/s: | 1.29.5 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Sergey Petushkov | Assignee: | Sergey Petushkov |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Epic Link: | COMPASS-4764 | ||||||||
| Story Points: | 2 | ||||||||
| Documentation Changes: | Not Needed | ||||||||
| Sprint: | Iteration Novokuybyshevsk, Iteration Orlando | ||||||||
| Description |
|
Currently it's pretty hard to make changes to dataService.instance method due to the code using outdated async library for flow control. Even though at some point this was the best approach, we can simplify the code a lot by refactoring it to async/await. This will allow us to make changes to the method easier later down the road maurizio.casimirri did a POC refactor that can be a good starting point Note: in scope of this ticket we DO NOT want to change the method behavior, it should still resolve all the data as it was doing before, these changes will come later Miro board with changes context |
| Comments |
| Comment by Githook User [ 27/Oct/21 ] |
|
Author: {'name': 'Sergey', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}Message: chore(mongodb-data-service): Refactor `dataService.instance` method
Co-Authored-By: Maurizio Casimirri <maurizio.cas@gmail.com>
Co-authored-by: Maurizio Casimirri <maurizio.cas@gmail.com> |
| Comment by Githook User [ 26/Oct/21 ] |
|
Author: {'name': 'Sergey', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}Message: chore(mongodb-data-service): Refactor `dataService.instance` method
Co-Authored-By: Maurizio Casimirri <maurizio.cas@gmail.com>
Co-authored-by: Maurizio Casimirri <maurizio.cas@gmail.com> |
| Comment by Githook User [ 26/Oct/21 ] |
|
Author: {'name': 'Sergey', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}Message: chore(mongodb-data-service): Refactor `dataService.instance` method
Co-Authored-By: Maurizio Casimirri <maurizio.cas@gmail.com>
Co-authored-by: Maurizio Casimirri <maurizio.cas@gmail.com> |
| Comment by Githook User [ 26/Oct/21 ] |
|
Author: {'name': 'Sergey', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}Message: chore(mongodb-data-service): Refactor `dataService.instance` method
Co-Authored-By: Maurizio Casimirri <maurizio.cas@gmail.com>
Co-authored-by: Maurizio Casimirri <maurizio.cas@gmail.com> |