[COMPASS-5239] Ensure connectionModel.secrets are encrypted Created: 27/Oct/21  Updated: 29/Oct/23  Resolved: 24/Feb/22

Status: Closed
Project: Compass
Component/s: None
Affects Version/s: None
Fix Version/s: 1.31.0

Type: Task Priority: Major - P3
Reporter: Maurizio Casimirri Assignee: Basit Chonka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to COMPASS-5393 Add tests for storing secrets Open
Epic Link: COMPASS-4948
Story Points: 1
Documentation Changes: Not Needed
Sprint: Iteration Phnom Penh, Iteration Q, Iteration Reno, Iteration Seoul, Iteration Utica, Iteration Versailles

 Description   

Follow up from COMPASS-4630, we just need to check that secrets are not stored in clear, tests in COMPASS-4630 only use a mock `storage-mixin` and we need to integrate ConnectionStorage before we are able to check that the encryption really takes place.

We need to verify that in the connection files saved by ConnectionStorage (packages/data-service) there is no secrets section or secrets saved in clear (see https://github.com/mongodb-js/compass/blob/main/packages/data-service/src/connection-secrets.ts).

Also we need to verify that the secrets are stored in the keychain instead.



 Comments   
Comment by Githook User [ 25/Feb/22 ]

Author:

{'name': 'Basit', 'email': '1305718+mabaasit@users.noreply.github.com', 'username': 'mabaasit'}

Message: fix(connections): hide sslPass in ampersand COMPASS-5239 (#2816)
Branch: 1.31-releases
https://github.com/mongodb-js/compass/commit/0f3cf17991b5353f977326efb8efd641ebe3b349

Comment by Githook User [ 23/Feb/22 ]

Author:

{'name': 'Basit', 'email': '1305718+mabaasit@users.noreply.github.com', 'username': 'mabaasit'}

Message: fix(connections): hide sslPass in ampersand COMPASS-5239 (#2816)
Branch: COMPASS-5506-update-item
https://github.com/mongodb-js/compass/commit/0f3cf17991b5353f977326efb8efd641ebe3b349

Comment by Githook User [ 22/Feb/22 ]

Author:

{'name': 'Basit', 'email': '1305718+mabaasit@users.noreply.github.com', 'username': 'mabaasit'}

Message: fix(connections): hide sslPass in ampersand COMPASS-5239 (#2816)
Branch: COMPASS-5511-make-connection-form-a-form
https://github.com/mongodb-js/compass/commit/0f3cf17991b5353f977326efb8efd641ebe3b349

Comment by Githook User [ 22/Feb/22 ]

Author:

{'name': 'Basit', 'email': '1305718+mabaasit@users.noreply.github.com', 'username': 'mabaasit'}

Message: fix(connections): hide sslPass in ampersand COMPASS-5239 (#2816)
Branch: move-query-history-to-left-of-query-bar
https://github.com/mongodb-js/compass/commit/0f3cf17991b5353f977326efb8efd641ebe3b349

Comment by Githook User [ 22/Feb/22 ]

Author:

{'name': 'Basit', 'email': '1305718+mabaasit@users.noreply.github.com', 'username': 'mabaasit'}

Message: fix(connections): hide sslPass in ampersand COMPASS-5239 (#2816)
Branch: remove-bootstrap
https://github.com/mongodb-js/compass/commit/0f3cf17991b5353f977326efb8efd641ebe3b349

Comment by Githook User [ 22/Feb/22 ]

Author:

{'name': 'Basit', 'email': '1305718+mabaasit@users.noreply.github.com', 'username': 'mabaasit'}

Message: fix(connections): hide sslPass in ampersand COMPASS-5239 (#2816)
Branch: main
https://github.com/mongodb-js/compass/commit/0f3cf17991b5353f977326efb8efd641ebe3b349

Generated at Wed Feb 07 22:38:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.