[COMPASS-5328] Manage react-ace as a peerDep Created: 29/Nov/21  Updated: 27/Oct/23  Resolved: 17/May/23

Status: Closed
Project: Compass
Component/s: Tech debt
Affects Version/s: None
Fix Version/s: No version

Type: Task Priority: Major - P3
Reporter: Le Roux Bodenstein Assignee: Unassigned
Resolution: Gone away Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to COMPASS-4528 Upgrade compass-aggregations to react... Closed
Documentation Changes: Not Needed

 Description   

 

ace seems to really want to be a global singleton, so best to make sure we only build and load one copy of it.

Thread: https://mongodb.slack.com/archives/G2L10JAV7/p1638184873399500

less things are trying to bundle this code with side effects treating it as a peer dependency, less libraries will need 1) to have special build setup for this 2) worry about different versions of this library running on the page. If only the host app is responsible for having ace editor available, the host app is the only one that would need to do custom Webpack config to make it work and will be responsible for the version number, being used which means that e.g., Charts or Cloud will not have issues in the future where they are blocked by us on the HIPAA issues due to our dependencies being outdated.

 

See

https://jira.mongodb.org/browse/COMPASS-4528

https://github.com/mongodb-js/compass/pull/2603

https://github.com/mongodb-js/mongosh/pull/1163

 



 Comments   
Comment by Rhys Howell [ 17/May/23 ]

No more react ace  🙌

Generated at Wed Feb 07 22:39:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.