[COMPASS-5428] Use leafygreen or vscode styles on a single form Created: 17/Jan/22  Updated: 26/Jan/22  Resolved: 26/Jan/22

Status: Closed
Project: Compass
Component/s: None
Affects Version/s: None
Fix Version/s: No version

Type: Investigation Priority: Major - P3
Reporter: Alena Khineika Assignee: Alena Khineika
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screenshot 2022-01-25 at 17.18.05.png     PNG File Screenshot 2022-01-25 at 17.19.23.png    
Issue Links:
Depends
is depended on by COMPASS-5345 Use a unified connection form in Comp... Closed
Epic Link: COMPASS-5198
Documentation Changes: Not Needed
Sprint: Iteration Seoul, Iteration Tokyo

 Description   

Compass mostly uses Leafygreen UI Kit with support for lite and dark mode, whereas VSCode currently uses Compass styles adapted to the user's color theme selected in VSCode. It means that VSCode has not only a light and dark mode, but many other supported color themes. Another thing that we should take into consideration is the recent release of Webview UI Toolkit for Visual Studio Code, using of which is recommended by VSCode authors and allows the extension to look, feel, and act like the editor itself.

We could consider the following options how to address it:

  • Pass color values to the form, that would allow us to support more color themes in VSCode that Compass needs.
  • Pass the components to the form that would allow us to have differently styled (from different UI Kits) components in Compass and VSCode.
  • Have separate forms but use the same middle layer with form handlers. In this case, we still have to maintain UIs but at least form actions and functional tests can be unified.


 Comments   
Comment by Githook User [ 26/Jan/22 ]

Author:

{'name': 'Alena Khineika', 'email': 'alena.khineika@gmail.com', 'username': 'alenakhineika'}

Message: feat: unified connect form compass and vscode COMPASS-5428
Branch: COMPASS-5428-unified-connect-form-compass-and-vscode
https://github.com/mongodb-js/compass/commit/600433b4600a532fe67df403d205556386b41a56

Comment by Githook User [ 26/Jan/22 ]

Author:

{'name': 'Alena Khineika', 'email': 'alena.khineika@gmail.com', 'username': 'alenakhineika'}

Message: feat: unified connect form compass and vscode COMPASS-5428
Branch: COMPASS-5428-unified-connect-form-compass-and-vscode
https://github.com/mongodb-js/vscode/commit/45235ee27cd5b43d09801f5701d21d6a747c3019

Generated at Wed Feb 07 22:39:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.