[COMPASS-5448] Compass fails to load any saved pipelines if any of them are not valid JSON Created: 21/Jan/22  Updated: 29/Oct/23  Resolved: 03/Nov/22

Status: Closed
Project: Compass
Component/s: Aggregation pipeline
Affects Version/s: None
Fix Version/s: 1.34.0

Type: Bug Priority: Major - P3
Reporter: Sergey Petushkov Assignee: Sergey Petushkov
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Epic Link: COMPASS-5403
Documentation Changes: Not Needed
Sprint: Iteration Narwhal

 Description   

Problem Statement/Rationale

If you have a unparseable JSON file saved as a pipeline, Compass will fail when trying to load it and will stop loading all other pipelines

Steps to Reproduce

  • Save a few pipelines in Compass
  • Corrupt a saved pipeline file in the SavedPipelines directory for any saved pipeline
  • Restart Compass and try to use saved pipelines

Expected Results

Probably you should see all pipelines that are parseable

Actual Results

You see no pipelines

Additional Notes

Maybe worth adding some logging there for the cases when loading a pipeline fails



 Comments   
Comment by Githook User [ 01/Dec/22 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches COMPASS-5448 (#3654)

  • chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches
  • chore: fix tests
  • chore: fix package.json

this plugin needs bootstrap now because other plugins
depend on its compiled assets
Branch: update-compass-shell-to-shared-config
https://github.com/mongodb-js/compass/commit/4a9cde7ffc5833f0367973675b59946233a4ed7c

Comment by Githook User [ 11/Nov/22 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches COMPASS-5448 (#3654)

  • chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches
  • chore: fix tests
  • chore: fix package.json

this plugin needs bootstrap now because other plugins
depend on its compiled assets
Branch: compass-6057-refactor-auto-updates
https://github.com/mongodb-js/compass/commit/4a9cde7ffc5833f0367973675b59946233a4ed7c

Comment by Githook User [ 02/Nov/22 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches COMPASS-5448 (#3654)

  • chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches
  • chore: fix tests
  • chore: fix package.json

this plugin needs bootstrap now because other plugins
depend on its compiled assets
Branch: remove-last-globally-impacting-all-scope-global-styles
https://github.com/mongodb-js/compass/commit/4a9cde7ffc5833f0367973675b59946233a4ed7c

Comment by Githook User [ 02/Nov/22 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches COMPASS-5448 (#3654)

  • chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches
  • chore: fix tests
  • chore: fix package.json

this plugin needs bootstrap now because other plugins
depend on its compiled assets
Branch: 1.34-releases
https://github.com/mongodb-js/compass/commit/4a9cde7ffc5833f0367973675b59946233a4ed7c

Comment by Githook User [ 01/Nov/22 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches COMPASS-5448 (#3654)

  • chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches
  • chore: fix tests
  • chore: fix package.json

this plugin needs bootstrap now because other plugins
depend on its compiled assets
Branch: dependabot/npm_and_yarn/terser-4.8.1
https://github.com/mongodb-js/compass/commit/4a9cde7ffc5833f0367973675b59946233a4ed7c

Comment by Githook User [ 01/Nov/22 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches COMPASS-5448 (#3654)

  • chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches
  • chore: fix tests
  • chore: fix package.json

this plugin needs bootstrap now because other plugins
depend on its compiled assets
Branch: COMPASS-6257-out-merge-preview
https://github.com/mongodb-js/compass/commit/4a9cde7ffc5833f0367973675b59946233a4ed7c

Comment by Githook User [ 31/Oct/22 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches COMPASS-5448 (#3654)

  • chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches
  • chore: fix tests
  • chore: fix package.json

this plugin needs bootstrap now because other plugins
depend on its compiled assets
Branch: COMPASS-6256-expand-collapse
https://github.com/mongodb-js/compass/commit/4a9cde7ffc5833f0367973675b59946233a4ed7c

Comment by Githook User [ 29/Oct/22 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches COMPASS-5448 (#3654)

  • chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches
  • chore: fix tests
  • chore: fix package.json

this plugin needs bootstrap now because other plugins
depend on its compiled assets
Branch: COMPASS-6064-implement-readonly-option
https://github.com/mongodb-js/compass/commit/4a9cde7ffc5833f0367973675b59946233a4ed7c

Comment by Githook User [ 28/Oct/22 ]

Author:

{'name': 'Sergey Petushkov', 'email': 'petushkov.sergey@gmail.com', 'username': 'gribnoysup'}

Message: chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches COMPASS-5448 (#3654)

  • chore(compass-saved-aggregations-queries): validate loaded saved pipelines to make sure that the schema matches
  • chore: fix tests
  • chore: fix package.json

this plugin needs bootstrap now because other plugins
depend on its compiled assets
Branch: main
https://github.com/mongodb-js/compass/commit/4a9cde7ffc5833f0367973675b59946233a4ed7c

Generated at Wed Feb 07 22:39:36 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.