[COMPASS-5481] Replace UnsafeComponent wrapper with ErrorBoundary wrapper in compass-components Created: 02/Feb/22 Updated: 07/Feb/22 Resolved: 07/Feb/22 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.31.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Rhys Howell | Assignee: | Rhys Howell |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 3 |
| Documentation Changes: | Not Needed |
| Sprint: | Iteration Utica |
| Description |
|
We'd like to have all of Compass on one react root so that any context, like the current theme of Compass, that is in the tree can be used by contained elements. Currently the UnsafeComponent https://github.com/mongodb-js/compass/blob/main/packages/hadron-react-components/src/unsafe-component.jsx in Compass renders new react roots for the components it wraps. This makes the context not passable from compass-home to pages like compass-aggregations. The views where the unsafe component wrapper is used are the Workspace, Database, and Collection views. This will involves some style updates in Compass as UnsafeComponent currently has some styling influence. |
| Comments |
| Comment by Githook User [ 07/Feb/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: chore: Replace UnsafeComponent wrapper component with ErrorBoundary |
| Comment by Githook User [ 04/Feb/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: chore: Replace UnsafeComponent wrapper component with ErrorBoundary |
| Comment by Githook User [ 04/Feb/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: chore: Replace UnsafeComponent wrapper component with ErrorBoundary |
| Comment by Githook User [ 03/Feb/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: chore: Replace UnsafeComponent wrapper component with ErrorBoundary |
| Comment by Githook User [ 03/Feb/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: chore: Replace UnsafeComponent wrapper component with ErrorBoundary |