[COMPASS-5520] Create COMPASS_LG_DARKMODE feature flag to enable leafygreen dark more Created: 17/Feb/22  Updated: 18/Mar/22  Resolved: 03/Mar/22

Status: Closed
Project: Compass
Component/s: UI / UX
Affects Version/s: None
Fix Version/s: No version

Type: Task Priority: Major - P3
Reporter: Rhys Howell Assignee: Rhys Howell
Resolution: Done Votes: 0
Labels: dark-mode, theme
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by COMPASS-5521 Add container component that wraps wo... Closed
Related
related to COMPASS-5289 Add theme context to Confirmation Mod... Closed
Epic Link: COMPASS-5480
Story Points: 3
Documentation Changes: Not Needed
Sprint: Iteration Wolverhampton

 Description   

Let's add a new COMPASS_LG_DARKMODE feature flag (off by default).

When the COMPASS_LG_DARKMODE is enabled the components in compass-components that use leafygreen should pass the darkMode=true to leafygreen components. It may make sense to create a High Order Component (HOC) for this. Additionally, when the feature flag is enabled, the `darkreader` should not enable itself:
https://github.com/mongodb-js/compass/blob/main/packages/compass/src/app/theme.js#L15

Note: We currently have an override for the leafygreen toggle that uses leafygreen's darkmode already. We should preserve that with and without the feature flag.



 Comments   
Comment by Githook User [ 07/Mar/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: feat(compass-components): add feature flag for using theme in components instead of darkreader theming COMPASS-5520 (#2856)
Branch: 1.31-releases
https://github.com/mongodb-js/compass/commit/36025f5a9b185e3ea4efbe41d19a7e24dbf0f238

Comment by Githook User [ 07/Mar/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: feat(compass-components): add feature flag for using theme in components instead of darkreader theming COMPASS-5520 (#2856)
Branch: COMPASS-5534-toolbar-implementation
https://github.com/mongodb-js/compass/commit/36025f5a9b185e3ea4efbe41d19a7e24dbf0f238

Comment by Githook User [ 03/Mar/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: feat(compass-components): add feature flag for using theme in components instead of darkreader theming COMPASS-5520 (#2856)
Branch: COMPASS-5517-remove-tab-nav-bar-component
https://github.com/mongodb-js/compass/commit/36025f5a9b185e3ea4efbe41d19a7e24dbf0f238

Comment by Githook User [ 03/Mar/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: feat(compass-components): add feature flag for using theme in components instead of darkreader theming COMPASS-5520 (#2856)
Branch: main
https://github.com/mongodb-js/compass/commit/36025f5a9b185e3ea4efbe41d19a7e24dbf0f238

Comment by Githook User [ 03/Mar/22 ]

Author:

{'name': 'Anemy', 'email': 'rhysh@live.com', 'username': 'Anemy'}

Message: Merge branch 'main' into COMPASS-5520-add-leafygreen-dark-mode-flag
Branch: COMPASS-5520-add-leafygreen-dark-mode-flag
https://github.com/mongodb-js/compass/commit/7af2fbba7b1ae6da2e9f10752ba3547c108961f9

Comment by Githook User [ 02/Mar/22 ]

Author:

{'name': 'Anemy', 'email': 'rhysh@live.com', 'username': 'Anemy'}

Message: Merge branch 'main' into COMPASS-5520-add-leafygreen-dark-mode-flag
Branch: COMPASS-5520-add-leafygreen-dark-mode-flag
https://github.com/mongodb-js/compass/commit/b4655461f429343971fb0c52ff4d854c54867109

Comment by Githook User [ 01/Mar/22 ]

Author:

{'name': 'Anemy', 'email': 'rhysh@live.com', 'username': 'Anemy'}

Message: Merge branch 'main' into COMPASS-5520-add-leafygreen-dark-mode-flag
Branch: COMPASS-5520-add-leafygreen-dark-mode-flag
https://github.com/mongodb-js/compass/commit/f2ea714b2b4f1e927af1453377e72e32e82b87ac

Generated at Wed Feb 07 22:39:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.