[COMPASS-5520] Create COMPASS_LG_DARKMODE feature flag to enable leafygreen dark more Created: 17/Feb/22 Updated: 18/Mar/22 Resolved: 03/Mar/22 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | UI / UX |
| Affects Version/s: | None |
| Fix Version/s: | No version |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Rhys Howell | Assignee: | Rhys Howell |
| Resolution: | Done | Votes: | 0 |
| Labels: | dark-mode, theme | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Epic Link: | COMPASS-5480 | ||||||||||||||||
| Story Points: | 3 | ||||||||||||||||
| Documentation Changes: | Not Needed | ||||||||||||||||
| Sprint: | Iteration Wolverhampton | ||||||||||||||||
| Description |
|
Let's add a new COMPASS_LG_DARKMODE feature flag (off by default). When the COMPASS_LG_DARKMODE is enabled the components in compass-components that use leafygreen should pass the darkMode=true to leafygreen components. It may make sense to create a High Order Component (HOC) for this. Additionally, when the feature flag is enabled, the `darkreader` should not enable itself: Note: We currently have an override for the leafygreen toggle that uses leafygreen's darkmode already. We should preserve that with and without the feature flag. |
| Comments |
| Comment by Githook User [ 07/Mar/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: feat(compass-components): add feature flag for using theme in components instead of darkreader theming |
| Comment by Githook User [ 07/Mar/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: feat(compass-components): add feature flag for using theme in components instead of darkreader theming |
| Comment by Githook User [ 03/Mar/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: feat(compass-components): add feature flag for using theme in components instead of darkreader theming |
| Comment by Githook User [ 03/Mar/22 ] |
|
Author: {'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}Message: feat(compass-components): add feature flag for using theme in components instead of darkreader theming |
| Comment by Githook User [ 03/Mar/22 ] |
|
Author: {'name': 'Anemy', 'email': 'rhysh@live.com', 'username': 'Anemy'}Message: Merge branch 'main' into |
| Comment by Githook User [ 02/Mar/22 ] |
|
Author: {'name': 'Anemy', 'email': 'rhysh@live.com', 'username': 'Anemy'}Message: Merge branch 'main' into |
| Comment by Githook User [ 01/Mar/22 ] |
|
Author: {'name': 'Anemy', 'email': 'rhysh@live.com', 'username': 'Anemy'}Message: Merge branch 'main' into |