[COMPASS-5522] Replace places in compass where confirmation modal used for forms with custom form modal component Created: 18/Feb/22  Updated: 02/Nov/22  Resolved: 26/Oct/22

Status: Closed
Project: Compass
Component/s: Tech debt
Affects Version/s: None
Fix Version/s: 1.34.0

Type: Task Priority: Major - P3
Reporter: Sergey Petushkov Assignee: Le Roux Bodenstein
Resolution: Done Votes: 0
Labels: milestone-3
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to COMPASS-5056 Update Compass modals with LeafyGreen... Closed
is related to COMPASS-6133 Remove usage of Modal component from ... Closed
Epic Link: COMPASS-5388
Story Points: 5
Documentation Changes: Not Needed
Sprint: Iteration Lobster, Iteration Manatee, Iteration Narwhal

 Description   

leafygreen team doesn't allow to use confirmation modals for form and suggests that we build our own component for that use-case (see this slack thread)



 Comments   
Comment by Githook User [ 02/Nov/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore: FormModal, ModalHeader, ModalContent COMPASS-5522 (#3582)

  • WIP
  • convert ConfirmationModals that should be FormModals
  • convert more modals
  • clean
  • e2e fixes
  • deal with buttons
  • also fix menuitem buttons
  • undo the combobox marginTop hack
  • feedback to scrollClassName and ModalContent -> ModalBody
  • rename shell info modal to avoid confusion
  • info modal
  • lint
  • fix test
  • scroll was inverted
  • more test fixes
  • leave compass-indexes alone
  • move modals into a folder
  • duplicate screenshot
  • unnnecessary whitespace
  • fix paths
  • double type
  • whitespace
  • fixes to selectors
  • remove debug screenshot
  • tweak timeouts
  • style property rather
  • cx, not css
  • move darkMode styles
  • remove stray import
Comment by Githook User [ 02/Nov/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore: FormModal, ModalHeader, ModalContent COMPASS-5522 (#3582)

  • WIP
  • convert ConfirmationModals that should be FormModals
  • convert more modals
  • clean
  • e2e fixes
  • deal with buttons
  • also fix menuitem buttons
  • undo the combobox marginTop hack
  • feedback to scrollClassName and ModalContent -> ModalBody
  • rename shell info modal to avoid confusion
  • info modal
  • lint
  • fix test
  • scroll was inverted
  • more test fixes
  • leave compass-indexes alone
  • move modals into a folder
  • duplicate screenshot
  • unnnecessary whitespace
  • fix paths
  • double type
  • whitespace
  • fixes to selectors
  • remove debug screenshot
  • tweak timeouts
  • style property rather
  • cx, not css
  • move darkMode styles
  • remove stray import
Comment by Githook User [ 27/Oct/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore: FormModal, ModalHeader, ModalContent COMPASS-5522 (#3582)

  • WIP
  • convert ConfirmationModals that should be FormModals
  • convert more modals
  • clean
  • e2e fixes
  • deal with buttons
  • also fix menuitem buttons
  • undo the combobox marginTop hack
  • feedback to scrollClassName and ModalContent -> ModalBody
  • rename shell info modal to avoid confusion
  • info modal
  • lint
  • fix test
  • scroll was inverted
  • more test fixes
  • leave compass-indexes alone
  • move modals into a folder
  • duplicate screenshot
  • unnnecessary whitespace
  • fix paths
  • double type
  • whitespace
  • fixes to selectors
  • remove debug screenshot
  • tweak timeouts
  • style property rather
  • cx, not css
  • move darkMode styles
  • remove stray import
Comment by Githook User [ 27/Oct/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore: FormModal, ModalHeader, ModalContent COMPASS-5522 (#3582)

  • WIP
  • convert ConfirmationModals that should be FormModals
  • convert more modals
  • clean
  • e2e fixes
  • deal with buttons
  • also fix menuitem buttons
  • undo the combobox marginTop hack
  • feedback to scrollClassName and ModalContent -> ModalBody
  • rename shell info modal to avoid confusion
  • info modal
  • lint
  • fix test
  • scroll was inverted
  • more test fixes
  • leave compass-indexes alone
  • move modals into a folder
  • duplicate screenshot
  • unnnecessary whitespace
  • fix paths
  • double type
  • whitespace
  • fixes to selectors
  • remove debug screenshot
  • tweak timeouts
  • style property rather
  • cx, not css
  • move darkMode styles
  • remove stray import
Comment by Githook User [ 27/Oct/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore: FormModal, ModalHeader, ModalContent COMPASS-5522 (#3582)

  • WIP
  • convert ConfirmationModals that should be FormModals
  • convert more modals
  • clean
  • e2e fixes
  • deal with buttons
  • also fix menuitem buttons
  • undo the combobox marginTop hack
  • feedback to scrollClassName and ModalContent -> ModalBody
  • rename shell info modal to avoid confusion
  • info modal
  • lint
  • fix test
  • scroll was inverted
  • more test fixes
  • leave compass-indexes alone
  • move modals into a folder
  • duplicate screenshot
  • unnnecessary whitespace
  • fix paths
  • double type
  • whitespace
  • fixes to selectors
  • remove debug screenshot
  • tweak timeouts
  • style property rather
  • cx, not css
  • move darkMode styles
  • remove stray import
Comment by Githook User [ 26/Oct/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore: FormModal, ModalHeader, ModalContent COMPASS-5522 (#3582)

  • WIP
  • convert ConfirmationModals that should be FormModals
  • convert more modals
  • clean
  • e2e fixes
  • deal with buttons
  • also fix menuitem buttons
  • undo the combobox marginTop hack
  • feedback to scrollClassName and ModalContent -> ModalBody
  • rename shell info modal to avoid confusion
  • info modal
  • lint
  • fix test
  • scroll was inverted
  • more test fixes
  • leave compass-indexes alone
  • move modals into a folder
  • duplicate screenshot
  • unnnecessary whitespace
  • fix paths
  • double type
  • whitespace
  • fixes to selectors
  • remove debug screenshot
  • tweak timeouts
  • style property rather
  • cx, not css
  • move darkMode styles
  • remove stray import
Comment by Githook User [ 26/Oct/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore: FormModal, ModalHeader, ModalContent COMPASS-5522 (#3582)

  • WIP
  • convert ConfirmationModals that should be FormModals
  • convert more modals
  • clean
  • e2e fixes
  • deal with buttons
  • also fix menuitem buttons
  • undo the combobox marginTop hack
  • feedback to scrollClassName and ModalContent -> ModalBody
  • rename shell info modal to avoid confusion
  • info modal
  • lint
  • fix test
  • scroll was inverted
  • more test fixes
  • leave compass-indexes alone
  • move modals into a folder
  • duplicate screenshot
  • unnnecessary whitespace
  • fix paths
  • double type
  • whitespace
  • fixes to selectors
  • remove debug screenshot
  • tweak timeouts
  • style property rather
  • cx, not css
  • move darkMode styles
  • remove stray import
Comment by Githook User [ 26/Oct/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore: FormModal, ModalHeader, ModalContent COMPASS-5522 (#3582)

  • WIP
  • convert ConfirmationModals that should be FormModals
  • convert more modals
  • clean
  • e2e fixes
  • deal with buttons
  • also fix menuitem buttons
  • undo the combobox marginTop hack
  • feedback to scrollClassName and ModalContent -> ModalBody
  • rename shell info modal to avoid confusion
  • info modal
  • lint
  • fix test
  • scroll was inverted
  • more test fixes
  • leave compass-indexes alone
  • move modals into a folder
  • duplicate screenshot
  • unnnecessary whitespace
  • fix paths
  • double type
  • whitespace
  • fixes to selectors
  • remove debug screenshot
  • tweak timeouts
  • style property rather
  • cx, not css
  • move darkMode styles
  • remove stray import
Comment by Githook User [ 26/Oct/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore: FormModal, ModalHeader, ModalContent COMPASS-5522 (#3582)

  • WIP
  • convert ConfirmationModals that should be FormModals
  • convert more modals
  • clean
  • e2e fixes
  • deal with buttons
  • also fix menuitem buttons
  • undo the combobox marginTop hack
  • feedback to scrollClassName and ModalContent -> ModalBody
  • rename shell info modal to avoid confusion
  • info modal
  • lint
  • fix test
  • scroll was inverted
  • more test fixes
  • leave compass-indexes alone
  • move modals into a folder
  • duplicate screenshot
  • unnnecessary whitespace
  • fix paths
  • double type
  • whitespace
  • fixes to selectors
  • remove debug screenshot
  • tweak timeouts
  • style property rather
  • cx, not css
  • move darkMode styles
  • remove stray import
Generated at Wed Feb 07 22:39:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.