[COMPASS-5686] Add default link handler to Compass Created: 04/Apr/22 Updated: 22/Jun/23 Resolved: 22/Jun/23 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | Electron, Tech debt |
| Affects Version/s: | None |
| Fix Version/s: | No version |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Rhys Howell | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Story Points: | 3 | ||||||||||||
| Documentation Changes: | Not Needed | ||||||||||||
| Description |
|
Currently in Compass we handle links in two main ways: 1. If the link has `_blank` on it then when it is clicked it is handled by the `new-window` event in electron: 2. If the link doesn't have `_blank` on it then we currently do not handle the link handling unless the target of the event is an `a` element. This isn't always the case with links without `_blank` as there might be a `span` or something inside of the `a` tag which means this check isn't very robust. The check happens here in the `onLinkClick` function: In this ticket let's add another handler for the `will-navigate` web contents event to handle links that are clicked without `_blank`. Let's remove the handling that has the not fully covering `a` tag check as well (and keep the `new-window` handler) since it will no longer need to be used. Something like: ); `will-navigate` docs: https://www.electronjs.org/docs/latest/api/web-contents#event-will-navigate |
| Comments |
| Comment by Sergey Petushkov [ 22/Jun/23 ] |
| Comment by Githook User [ 21/Mar/23 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat(compass-schema,compass-schema-validation): more darkmode and maps fixes
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
--------- Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com> |
| Comment by Githook User [ 05/Mar/23 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat(compass-schema,compass-schema-validation): more darkmode and maps fixes
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
--------- Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com> |
| Comment by Githook User [ 03/Mar/23 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat(compass-schema,compass-schema-validation): more darkmode and maps fixes
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
--------- Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com> |
| Comment by Githook User [ 01/Mar/23 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat(compass-schema,compass-schema-validation): more darkmode and maps fixes
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
--------- Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com> |
| Comment by Githook User [ 01/Mar/23 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat(compass-schema,compass-schema-validation): more darkmode and maps fixes
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
--------- Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com> |
| Comment by Githook User [ 01/Mar/23 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat(compass-schema,compass-schema-validation): more darkmode and maps fixes
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
--------- Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com> |
| Comment by Githook User [ 01/Mar/23 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat(compass-schema,compass-schema-validation): more darkmode and maps fixes
Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
--------- Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com> |