[COMPASS-5847] Fix/remove compass-crud's disabled eslint accessibility rule breaks Created: 20/May/22  Updated: 03/Oct/23  Resolved: 27/Feb/23

Status: Closed
Project: Compass
Component/s: Accessibility, CRUD, Tech debt
Affects Version/s: None
Fix Version/s: No version

Type: Task Priority: Major - P3
Reporter: Rhys Howell Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on COMPASS-5824 Update `compass-crud` package config ... Closed
Related
is related to COMPASS-6139 Refactor usage of UNSAFE_ methods in ... Closed
Epic Link: COMPASS-5564
Story Points: 3
Documentation Changes: Not Needed
Sprint: Iteration Dolphin, Iteration Eel, Iteration Fish

 Description   

In updating `compass-crud` to the shared eslint config of Compass we encountered a number of places where the plugin was using non-interactive html elements as buttons with `onClick` handlers. Mostly in the documents table view. This ticket involves removing the places where we disabled eslint rules so that the lint `check` passes and we have less accessibility issues in Compass.

I tagged most of the places with this ticket number so you can search for that in the code base as well as the eslint-disabled rules below vvv

Rules:

  • Visible, non-interactive elements with click handlers must have at least one keyboard listener jsx-a11y/click-events-have-key-events
  • Static HTML elements with event handlers require a role jsx-a11y/no-static-element-interactions
  • Non-interactive elements should not be assigned mouse or keyboard event listeners jsx-a11y/no-noninteractive-element-interactions

Generated at Wed Feb 07 22:41:00 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.