[COMPASS-5900] Merge sidebar-only packages into the sidebar/compass components Created: 16/Jun/22  Updated: 28/Sep/22  Resolved: 27/Jul/22

Status: Closed
Project: Compass
Component/s: Sidebar
Affects Version/s: None
Fix Version/s: 1.32.6

Type: Task Priority: Major - P3
Reporter: Le Roux Bodenstein Assignee: Le Roux Bodenstein
Resolution: Done Votes: 0
Labels: leafygreen
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: COMPASS-5486
Story Points: 5
Documentation Changes: Not Needed
Sprint: Iteration Fish, Iteration Grouper

 Description   
  • compass-deployment-awareness
  • compass-server-version
  • compass-ssh-tunnel-status

 

The components in these only get used in compass-sidebar. It is pluggable but that's just tech debt since we only ever have these three.

 

compass-server-version and compass-ssh-tunnel-status are trivial to move and their state can just be merged into the compass-sidebar store.

 

compass-deployment-awareness is more complicated because it also owns some global events. It also has a WriteStateStore that is used directly by other plugins and it has one weird state-aware component (OptionWriteSelector) left is used by another plugin that will have to be changed. Shared per-instance state will be moved to the instance model and then these plugins can be removed.

 

By making this change now we avoid having to convert each of them to typescript, our modern linting, etc. We have to change every component in the sidebar into leafygreen components anyway, so none of them will remain unchanged. Therefore by eliminating them we should hopefully reduce the duplicate effort and we can get rid of this tech debt in the process.



 Comments   
Comment by Githook User [ 28/Sep/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(sidebar): merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar COMPASS-5900 (#3224)

  • merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar
  • add missing deps
  • remove references to the plugins
  • WIP
  • move state to the instance model
  • TODOs
  • move isWritable and instance description to the instance model
  • :lipstick:
  • fix up tests
  • remove more
  • rm TODO
  • TODO comments
  • rm debug
  • rm more things
  • fix schema valiation tests
  • prettier
  • tests for instance events in compass-collection
  • instance model derived prop tests
  • compass-schema-validation store tests
  • refactor sidebar state (WIP)
  • sidebar store tests
  • conection options tests
  • make depcheck happy
  • make checks happy
  • more depcheck
  • depcheck
  • state got moved
  • rm TODO
  • early return
  • version shouldn't be able to change anymore
  • type the connection-options module
Comment by Githook User [ 30/Aug/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(sidebar): merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar COMPASS-5900 (#3224)

  • merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar
  • add missing deps
  • remove references to the plugins
  • WIP
  • move state to the instance model
  • TODOs
  • move isWritable and instance description to the instance model
  • :lipstick:
  • fix up tests
  • remove more
  • rm TODO
  • TODO comments
  • rm debug
  • rm more things
  • fix schema valiation tests
  • prettier
  • tests for instance events in compass-collection
  • instance model derived prop tests
  • compass-schema-validation store tests
  • refactor sidebar state (WIP)
  • sidebar store tests
  • conection options tests
  • make depcheck happy
  • make checks happy
  • more depcheck
  • depcheck
  • state got moved
  • rm TODO
  • early return
  • version shouldn't be able to change anymore
  • type the connection-options module
Comment by Githook User [ 29/Jul/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(sidebar): merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar COMPASS-5900 (#3224)

  • merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar
  • add missing deps
  • remove references to the plugins
  • WIP
  • move state to the instance model
  • TODOs
  • move isWritable and instance description to the instance model
  • :lipstick:
  • fix up tests
  • remove more
  • rm TODO
  • TODO comments
  • rm debug
  • rm more things
  • fix schema valiation tests
  • prettier
  • tests for instance events in compass-collection
  • instance model derived prop tests
  • compass-schema-validation store tests
  • refactor sidebar state (WIP)
  • sidebar store tests
  • conection options tests
  • make depcheck happy
  • make checks happy
  • more depcheck
  • depcheck
  • state got moved
  • rm TODO
  • early return
  • version shouldn't be able to change anymore
  • type the connection-options module
Comment by Githook User [ 27/Jul/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(sidebar): merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar COMPASS-5900 (#3224)

  • merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar
  • add missing deps
  • remove references to the plugins
  • WIP
  • move state to the instance model
  • TODOs
  • move isWritable and instance description to the instance model
  • :lipstick:
  • fix up tests
  • remove more
  • rm TODO
  • TODO comments
  • rm debug
  • rm more things
  • fix schema valiation tests
  • prettier
  • tests for instance events in compass-collection
  • instance model derived prop tests
  • compass-schema-validation store tests
  • refactor sidebar state (WIP)
  • sidebar store tests
  • conection options tests
  • make depcheck happy
  • make checks happy
  • more depcheck
  • depcheck
  • state got moved
  • rm TODO
  • early return
  • version shouldn't be able to change anymore
  • type the connection-options module
Comment by Githook User [ 26/Jul/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(sidebar): merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar COMPASS-5900 (#3224)

  • merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar
  • add missing deps
  • remove references to the plugins
  • WIP
  • move state to the instance model
  • TODOs
  • move isWritable and instance description to the instance model
  • :lipstick:
  • fix up tests
  • remove more
  • rm TODO
  • TODO comments
  • rm debug
  • rm more things
  • fix schema valiation tests
  • prettier
  • tests for instance events in compass-collection
  • instance model derived prop tests
  • compass-schema-validation store tests
  • refactor sidebar state (WIP)
  • sidebar store tests
  • conection options tests
  • make depcheck happy
  • make checks happy
  • more depcheck
  • depcheck
  • state got moved
  • rm TODO
  • early return
  • version shouldn't be able to change anymore
  • type the connection-options module
Comment by Githook User [ 26/Jul/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(sidebar): merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar COMPASS-5900 (#3224)

  • merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar
  • add missing deps
  • remove references to the plugins
  • WIP
  • move state to the instance model
  • TODOs
  • move isWritable and instance description to the instance model
  • :lipstick:
  • fix up tests
  • remove more
  • rm TODO
  • TODO comments
  • rm debug
  • rm more things
  • fix schema valiation tests
  • prettier
  • tests for instance events in compass-collection
  • instance model derived prop tests
  • compass-schema-validation store tests
  • refactor sidebar state (WIP)
  • sidebar store tests
  • conection options tests
  • make depcheck happy
  • make checks happy
  • more depcheck
  • depcheck
  • state got moved
  • rm TODO
  • early return
  • version shouldn't be able to change anymore
  • type the connection-options module
Comment by Githook User [ 26/Jul/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(sidebar): merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar COMPASS-5900 (#3224)

  • merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar
  • add missing deps
  • remove references to the plugins
  • WIP
  • move state to the instance model
  • TODOs
  • move isWritable and instance description to the instance model
  • :lipstick:
  • fix up tests
  • remove more
  • rm TODO
  • TODO comments
  • rm debug
  • rm more things
  • fix schema valiation tests
  • prettier
  • tests for instance events in compass-collection
  • instance model derived prop tests
  • compass-schema-validation store tests
  • refactor sidebar state (WIP)
  • sidebar store tests
  • conection options tests
  • make depcheck happy
  • make checks happy
  • more depcheck
  • depcheck
  • state got moved
  • rm TODO
  • early return
  • version shouldn't be able to change anymore
  • type the connection-options module
Comment by Githook User [ 26/Jul/22 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: chore(sidebar): merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar COMPASS-5900 (#3224)

  • merge deploymentAwareness, serverVersion, sshTunnelStatus plugins into the sidebar
  • add missing deps
  • remove references to the plugins
  • WIP
  • move state to the instance model
  • TODOs
  • move isWritable and instance description to the instance model
  • :lipstick:
  • fix up tests
  • remove more
  • rm TODO
  • TODO comments
  • rm debug
  • rm more things
  • fix schema valiation tests
  • prettier
  • tests for instance events in compass-collection
  • instance model derived prop tests
  • compass-schema-validation store tests
  • refactor sidebar state (WIP)
  • sidebar store tests
  • conection options tests
  • make depcheck happy
  • make checks happy
  • more depcheck
  • depcheck
  • state got moved
  • rm TODO
  • early return
  • version shouldn't be able to change anymore
  • type the connection-options module
Generated at Wed Feb 07 22:41:10 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.