[COMPASS-5995] Create eslint rule to catch hardcoded colors, spacings and font sizes Created: 02/Aug/22  Updated: 28/Jun/23  Resolved: 21/Feb/23

Status: Closed
Project: Compass
Component/s: Tech debt
Affects Version/s: None
Fix Version/s: No version

Type: Task Priority: Major - P3
Reporter: Maurizio Casimirri Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Documentation Changes: Not Needed

 Description   

No matter how much effort we put into code reviews, we still have a number of hardcoded pixel spacings and font sizes.

We want to create one or more eslint rules to enforce the guidelines that we agreed upon on our Components Conventions document:

  • Components only use variables for colors, font sizes, etc.
  • Components only use LeafyGreen variables for colors, typography, and spacings.


 Comments   
Comment by Jessica Sigafoos [ 21/Feb/23 ]

Can reopen if this continues to come up

Generated at Wed Feb 07 22:41:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.