[COMPASS-6101] Use rebranded combobox code in compass-components and bind darkMode Created: 06/Sep/22 Updated: 05/Oct/22 Resolved: 04/Oct/22 |
|
| Status: | Closed |
| Project: | Compass |
| Component/s: | UI / UX |
| Affects Version/s: | None |
| Fix Version/s: | 1.34.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Maurizio Casimirri | Assignee: | Maurizio Casimirri |
| Resolution: | Done | Votes: | 0 |
| Labels: | milestone-2 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Epic Link: | COMPASS-5388 |
| Story Points: | 3 |
| Documentation Changes: | Not Needed |
| Sprint: | Iteration Kraken |
| Description |
|
The ComboBox code in components/leafy-green/combobox is currently based on the non-rebranded combobox to workaround: https://jira.mongodb.org/browse/PD-2321 To support the new brand we need to use the new component code there and remove again the buggy focus handling (https://mongodb.slack.com/archives/CFFA5BS79/p1660573498227609?thread_ts=1660573472.739789&cid=CFFA5BS79) and workaround the margin issue: See https://mongodb.slack.com/archives/CFFA5BS79/p1662450273800529 for a fix and https://jira.mongodb.org/browse/PD-2420 With the new component we also want to centralise the darkmode binding inside compass-components (as done for all the others) and get rid of the client code that applies those styles manually: |
| Comments |
| Comment by Githook User [ 05/Oct/22 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat: use rebranded combobox
|
| Comment by Githook User [ 29/Sep/22 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat: use rebranded combobox
|
| Comment by Githook User [ 28/Sep/22 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat: use rebranded combobox
|
| Comment by Githook User [ 23/Sep/22 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat: use rebranded combobox
|
| Comment by Githook User [ 23/Sep/22 ] |
|
Author: {'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}Message: feat: use rebranded combobox
|