[COMPASS-6111] If retrieving cloud telemetry info fails it defaults to false Created: 08/Sep/22  Updated: 29/Oct/23  Resolved: 16/Feb/23

Status: Closed
Project: Compass
Component/s: Telemetry Data
Affects Version/s: None
Fix Version/s: 1.36.0

Type: Bug Priority: Major - P3
Reporter: Le Roux Bodenstein Assignee: Le Roux Bodenstein
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 2
Documentation Changes: Not Needed
Sprint: Iteration Jellyfish, Iteration Lobster, Iteration Quahog, Iteration Ragfish, Iteration Seahorse, Iteration Turtle, Iteration Unicornfish, Iteration Velvet Crab

 Description   

See thread: https://mongodb.slack.com/archives/G2L10JAV7/p1662621306480259

If await getCloudInfo() times out we cast undefined to false and this skews our telemetry info.

Amplitude works just fine with undefined. Rather leave those as undefined (ie. "unknown").

I don't know how often this is wrong in "production", but it is actually always wrong (to various degrees) in our tests and CI.



 Comments   
Comment by Githook User [ 01/Mar/23 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: fix(telemetry): undefined rather than false if getCloudInfo fails, support SRV URIs COMPASS-6111 (#3451)

  • rather go with undefined than some arbitrary values
  • don't cast undefined to false
  • WIP
  • attempt to fix tests
  • add a valid dev domain
  • resolve SRV hostnames
  • more tests, tweak the src+nonexistent domain case
  • fix e2e test
  • clean up tests
  • Update packages/compass-connections/src/modules/telemetry.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • Update packages/compass-connections/src/modules/telemetry.ts

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • prettier

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: github-link
https://github.com/mongodb-js/compass/commit/3fc468b0c52c2f9355b5218dc80f37c9a1ef4874

Comment by Githook User [ 27/Feb/23 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: fix(telemetry): undefined rather than false if getCloudInfo fails, support SRV URIs COMPASS-6111 (#3451)

  • rather go with undefined than some arbitrary values
  • don't cast undefined to false
  • WIP
  • attempt to fix tests
  • add a valid dev domain
  • resolve SRV hostnames
  • more tests, tweak the src+nonexistent domain case
  • fix e2e test
  • clean up tests
  • Update packages/compass-connections/src/modules/telemetry.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • Update packages/compass-connections/src/modules/telemetry.ts

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • prettier

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: 1.35-releases
https://github.com/mongodb-js/compass/commit/3fc468b0c52c2f9355b5218dc80f37c9a1ef4874

Comment by Githook User [ 16/Feb/23 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: fix(telemetry): undefined rather than false if getCloudInfo fails, support SRV URIs COMPASS-6111 (#3451)

  • rather go with undefined than some arbitrary values
  • don't cast undefined to false
  • WIP
  • attempt to fix tests
  • add a valid dev domain
  • resolve SRV hostnames
  • more tests, tweak the src+nonexistent domain case
  • fix e2e test
  • clean up tests
  • Update packages/compass-connections/src/modules/telemetry.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • Update packages/compass-connections/src/modules/telemetry.ts

Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>

  • prettier

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Co-authored-by: Anna Henningsen <anna.henningsen@mongodb.com>
Branch: main
https://github.com/mongodb-js/compass/commit/3fc468b0c52c2f9355b5218dc80f37c9a1ef4874

Generated at Wed Feb 07 22:41:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.