[COMPASS-6132] Move the close button to the InteractivePopover and re-enable focus check Created: 16/Sep/22  Updated: 25/Oct/22  Resolved: 14/Oct/22

Status: Closed
Project: Compass
Component/s: None
Affects Version/s: None
Fix Version/s: No version

Type: Task Priority: Major - P3
Reporter: Maurizio Casimirri Assignee: Rhys Howell
Resolution: Done Votes: 0
Labels: milestone-3
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: COMPASS-5388
Story Points: 3
Documentation Changes: Not Needed
Sprint: Iteration Lobster, Iteration Manatee

 Description   

Move the close button from the client code directly in the InteractivePopover component since is part of the pattern, and use it as fallbackFocus instead of displayCheck: 'none'.

https://github.com/mongodb-js/compass/blob/9201f82f27220ac9795cb1bba97627366d9b1441/packages/compass-query-history/src/components/toolbar/toolbar.tsx#L136-L137

              tabbableOptions: {
                displayCheck: 'none',
              },
              fallbackFocus: 



 Comments   
Comment by Githook User [ 25/Oct/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: chore(components): move close button into the InteractivePopover COMPASS-6132 (#3571)
Branch: 6067-dev
https://github.com/mongodb-js/compass/commit/38ad2219a32b50664b382ab14ba5ff8142833bb8

Comment by Githook User [ 20/Oct/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: chore(components): move close button into the InteractivePopover COMPASS-6132 (#3571)
Branch: 1.34-releases
https://github.com/mongodb-js/compass/commit/38ad2219a32b50664b382ab14ba5ff8142833bb8

Comment by Githook User [ 19/Oct/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: chore(components): move close button into the InteractivePopover COMPASS-6132 (#3571)
Branch: COMPASS-6064-implement-readonly-option
https://github.com/mongodb-js/compass/commit/38ad2219a32b50664b382ab14ba5ff8142833bb8

Comment by Githook User [ 17/Oct/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: chore(components): move close button into the InteractivePopover COMPASS-6132 (#3571)
Branch: move-from-confirmation-modal
https://github.com/mongodb-js/compass/commit/38ad2219a32b50664b382ab14ba5ff8142833bb8

Comment by Githook User [ 17/Oct/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: chore(components): move close button into the InteractivePopover COMPASS-6132 (#3571)
Branch: update-compass-shell-to-shared-config
https://github.com/mongodb-js/compass/commit/38ad2219a32b50664b382ab14ba5ff8142833bb8

Comment by Githook User [ 14/Oct/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: chore(components): move close button into the InteractivePopover COMPASS-6132 (#3571)
Branch: main
https://github.com/mongodb-js/compass/commit/38ad2219a32b50664b382ab14ba5ff8142833bb8

Comment by Githook User [ 13/Oct/22 ]

Author:

{'name': 'Rhys', 'email': 'Anemy@users.noreply.github.com', 'username': 'Anemy'}

Message: Merge branch 'main' into COMPASS-6132-move-close-button-in-interactive-popover
Branch: COMPASS-6132-move-close-button-in-interactive-popover
https://github.com/mongodb-js/compass/commit/e0780fcb589895febd52ceb6651f48ce51b551e9

Generated at Wed Feb 07 22:42:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.