[COMPASS-6255] Investigate changes in NODE-4705: Remove Timestamp legacy constructor from low/high order bits Created: 26/Oct/22  Updated: 01/Feb/23  Resolved: 01/Feb/23

Status: Closed
Project: Compass
Component/s: None
Affects Version/s: None
Fix Version/s: No version

Type: Investigation Priority: Major - P3
Reporter: PM Bot Assignee: Unassigned
Resolution: Done Votes: 0
Labels: node-driver
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on NODE-4705 Remove Timestamp legacy constructor f... Closed
Documentation Changes: Not Needed

 Description   

Use Case

We deprecated the 2 argument Timestamp constructor taking low/high order bits. We should remove this constructor support.

User Impact

  • Migration will require code changes
    • Any instance of new Timestamp(low: number, high: number) will need to be wrapped in Long construction or broken into the i, t style constructor.

Acceptance Criteria

Implementation Requirements

  • Remove support for the constructor overload that takes two plain numbers as input
  • Since removing support will likely lead to a runtime error (props not existing etc.) add a helpful error to be thrown if this usage is detected.

Testing Requirements

  • Assert the constructor fails in the old usage case
  • Update any Timestamp tests to use the i, t style constructor


 Comments   
Comment by Anna Henningsen [ 01/Feb/23 ]

Handled by MONGOSH-1358

Generated at Wed Feb 07 22:42:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.