[COMPASS-6365] Json view is slow since Compass 1.34 Created: 12/Dec/22  Updated: 29/Oct/23  Resolved: 03/Jan/23

Status: Closed
Project: Compass
Component/s: JSON Mode, Performance
Affects Version/s: 1.34.1
Fix Version/s: 1.35.0

Type: Bug Priority: Major - P3
Reporter: Maurizio Casimirri Assignee: Maurizio Casimirri
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by COMPASS-6375 Cannot switch between document views Closed
Problem/Incident
causes COMPASS-6481 Replace ace editors in compass with c... Closed
Documentation Changes: Not Needed
Sprint: Iteration Seahorse

 Description   

See: https://mongodb.slack.com/archives/C0U7K0MC3/p1670799246030099
Created with Jira Integration+ for maurizio.casimirri (maurizio.casimirri@mongodb.com)

"Yes. In the example above, it took roughly 30s to switch with 1.34, while it “only” took maybe 3 seconds with 1.33 (for some reason Quicktime kept not recording the video of 1.33 so you have just to believe me )" - Max



 Comments   
Comment by Githook User [ 03/Jan/23 ]

Author:

{'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}

Message: fix: speed up document json view COMPASS-6365 (#3901)

  • tmp: first pass at adding codemirror instead of ace-editor

todo:

  • finish theme implementation
  • allow to disable background in the json view in document list
  • line numbers shouldn't be visible when readonly is true
  • chore(compass-editor): add support for controlled behavior; finalize styles adjustments
  • chore(compass-editor): better padding for gutter, align folding with the old behavior; reuse effectOnChange hook
  • chore(e2e): adjust e2e tests for the new json editor
  • chore(e2e): adjust regex

Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
Branch: fix-missing-name-prop
https://github.com/mongodb-js/compass/commit/ad291b14613b39c5ecf4e37055912d912d547c5b

Comment by Githook User [ 20/Dec/22 ]

Author:

{'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}

Message: fix: speed up document json view COMPASS-6365 (#3901)

  • tmp: first pass at adding codemirror instead of ace-editor

todo:

  • finish theme implementation
  • allow to disable background in the json view in document list
  • line numbers shouldn't be visible when readonly is true
  • chore(compass-editor): add support for controlled behavior; finalize styles adjustments
  • chore(compass-editor): better padding for gutter, align folding with the old behavior; reuse effectOnChange hook
  • chore(e2e): adjust e2e tests for the new json editor
  • chore(e2e): adjust regex

Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
Branch: 1.35-releases
https://github.com/mongodb-js/compass/commit/ad291b14613b39c5ecf4e37055912d912d547c5b

Comment by Githook User [ 20/Dec/22 ]

Author:

{'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}

Message: fix: speed up document json view COMPASS-6365 (#3901)

  • tmp: first pass at adding codemirror instead of ace-editor

todo:

  • finish theme implementation
  • allow to disable background in the json view in document list
  • line numbers shouldn't be visible when readonly is true
  • chore(compass-editor): add support for controlled behavior; finalize styles adjustments
  • chore(compass-editor): better padding for gutter, align folding with the old behavior; reuse effectOnChange hook
  • chore(e2e): adjust e2e tests for the new json editor
  • chore(e2e): adjust regex

Co-authored-by: Sergey Petushkov <petushkov.sergey@gmail.com>
Branch: main
https://github.com/mongodb-js/compass/commit/ad291b14613b39c5ecf4e37055912d912d547c5b

Comment by Githook User [ 16/Dec/22 ]

Author:

{'name': 'Maurizio Casimirri', 'email': 'maurizio.cas@gmail.com', 'username': 'mcasimir'}

Message: fix: speed up document json view COMPASS-6365
Branch: fix-json-slow
https://github.com/mongodb-js/compass/commit/63eb85e3cf8f89fca3356165515580dce22f55f3

Generated at Wed Feb 07 22:42:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.