[COMPASS-6637] Looser date type detection Created: 22/Mar/23  Updated: 24/Apr/23  Resolved: 11/Apr/23

Status: Closed
Project: Compass
Component/s: Import/Export
Affects Version/s: None
Fix Version/s: No version

Type: Task Priority: Major - P3
Reporter: Le Roux Bodenstein Assignee: Le Roux Bodenstein
Resolution: Done Votes: 0
Labels: milestone-5
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Epic Link: COMPASS-5576
Story Points: 2
Documentation Changes: Not Needed

 Description   

The ISO date regex copied from papaparse is a bit strict. For example the airbnb sample test data we often use has dates like:

2015-01-04 00:00:00

I've also seen:

2015-01-04

We can just make the relevant parts optional as both of those can safely be passed to new Date().

There are unit tests for this detection and we can just copy/paste and make some more. There's also test/csv/types/date.csv where we can add some examples. Some expected results may or may not have to be updated to match.

You can just focus the relevant files (.only on a describe somewhere) and run:

DEBUG=import npx mocha --bail src/import

for fast test turnaround.



 Comments   
Comment by Githook User [ 24/Apr/23 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: feat(export): exportCSV() COMPASS-6428 COMPASS-6521 COMPASS-6637 (#4219)

  • factor out common export types
  • exportCSV()
  • WIP
  • tests, fixes
  • fix for dataService changes
  • the objectId error changed
  • Update packages/compass-import-export/src/export/export-csv.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rename exportCSV
  • remove TODO I'm not going to do
  • Update packages/compass-import-export/src/import/import-types.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • Update packages/compass-import-export/test/docs/all-bson-types.js

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rm comment
  • Symbol is deprecated.
  • add comment
  • relaxed: false so that we can support BSONSymbol
  • test exporting an empty collection
  • test exporting md5 fields
  • fill out missing tests
  • relaxed: false so that numbers can't lie
  • I guess the safest, most viable way to export binary data is to base64 encode it
  • debug
  • more specific error check
  • os-specific newlines in log files
  • fix screenshots for CSFLE tests

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: COMPASS-6530-auto-add-curly-braces
https://github.com/mongodb-js/compass/commit/f9860daa2dcaae9385f03c56030911f159d0c9fd

Comment by Githook User [ 21/Apr/23 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: feat(export): exportCSV() COMPASS-6428 COMPASS-6521 COMPASS-6637 (#4219)

  • factor out common export types
  • exportCSV()
  • WIP
  • tests, fixes
  • fix for dataService changes
  • the objectId error changed
  • Update packages/compass-import-export/src/export/export-csv.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rename exportCSV
  • remove TODO I'm not going to do
  • Update packages/compass-import-export/src/import/import-types.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • Update packages/compass-import-export/test/docs/all-bson-types.js

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rm comment
  • Symbol is deprecated.
  • add comment
  • relaxed: false so that we can support BSONSymbol
  • test exporting an empty collection
  • test exporting md5 fields
  • fill out missing tests
  • relaxed: false so that numbers can't lie
  • I guess the safest, most viable way to export binary data is to base64 encode it
  • debug
  • more specific error check
  • os-specific newlines in log files
  • fix screenshots for CSFLE tests

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: 1.36-releases
https://github.com/mongodb-js/compass/commit/f9860daa2dcaae9385f03c56030911f159d0c9fd

Comment by Githook User [ 12/Apr/23 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: feat(export): exportCSV() COMPASS-6428 COMPASS-6521 COMPASS-6637 (#4219)

  • factor out common export types
  • exportCSV()
  • WIP
  • tests, fixes
  • fix for dataService changes
  • the objectId error changed
  • Update packages/compass-import-export/src/export/export-csv.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rename exportCSV
  • remove TODO I'm not going to do
  • Update packages/compass-import-export/src/import/import-types.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • Update packages/compass-import-export/test/docs/all-bson-types.js

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rm comment
  • Symbol is deprecated.
  • add comment
  • relaxed: false so that we can support BSONSymbol
  • test exporting an empty collection
  • test exporting md5 fields
  • fill out missing tests
  • relaxed: false so that numbers can't lie
  • I guess the safest, most viable way to export binary data is to base64 encode it
  • debug
  • more specific error check
  • os-specific newlines in log files
  • fix screenshots for CSFLE tests

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: COMPASS-6655-sort-use-case
https://github.com/mongodb-js/compass/commit/f9860daa2dcaae9385f03c56030911f159d0c9fd

Comment by Githook User [ 11/Apr/23 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: feat(export): exportCSV() COMPASS-6428 COMPASS-6521 COMPASS-6637 (#4219)

  • factor out common export types
  • exportCSV()
  • WIP
  • tests, fixes
  • fix for dataService changes
  • the objectId error changed
  • Update packages/compass-import-export/src/export/export-csv.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rename exportCSV
  • remove TODO I'm not going to do
  • Update packages/compass-import-export/src/import/import-types.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • Update packages/compass-import-export/test/docs/all-bson-types.js

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rm comment
  • Symbol is deprecated.
  • add comment
  • relaxed: false so that we can support BSONSymbol
  • test exporting an empty collection
  • test exporting md5 fields
  • fill out missing tests
  • relaxed: false so that numbers can't lie
  • I guess the safest, most viable way to export binary data is to base64 encode it
  • debug
  • more specific error check
  • os-specific newlines in log files
  • fix screenshots for CSFLE tests

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: COMPASS-6676-support-for-stage-wizard-in-stage-editor-store
https://github.com/mongodb-js/compass/commit/f9860daa2dcaae9385f03c56030911f159d0c9fd

Comment by Githook User [ 11/Apr/23 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: feat(export): exportCSV() COMPASS-6428 COMPASS-6521 COMPASS-6637 (#4219)

  • factor out common export types
  • exportCSV()
  • WIP
  • tests, fixes
  • fix for dataService changes
  • the objectId error changed
  • Update packages/compass-import-export/src/export/export-csv.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rename exportCSV
  • remove TODO I'm not going to do
  • Update packages/compass-import-export/src/import/import-types.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • Update packages/compass-import-export/test/docs/all-bson-types.js

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rm comment
  • Symbol is deprecated.
  • add comment
  • relaxed: false so that we can support BSONSymbol
  • test exporting an empty collection
  • test exporting md5 fields
  • fill out missing tests
  • relaxed: false so that numbers can't lie
  • I guess the safest, most viable way to export binary data is to base64 encode it
  • debug
  • more specific error check
  • os-specific newlines in log files
  • fix screenshots for CSFLE tests

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: COMPASS-6577-add-export-modal
https://github.com/mongodb-js/compass/commit/f9860daa2dcaae9385f03c56030911f159d0c9fd

Comment by Githook User [ 11/Apr/23 ]

Author:

{'name': 'Le Roux Bodenstein', 'email': 'lerouxb@gmail.com', 'username': 'lerouxb'}

Message: feat(export): exportCSV() COMPASS-6428 COMPASS-6521 COMPASS-6637 (#4219)

  • factor out common export types
  • exportCSV()
  • WIP
  • tests, fixes
  • fix for dataService changes
  • the objectId error changed
  • Update packages/compass-import-export/src/export/export-csv.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rename exportCSV
  • remove TODO I'm not going to do
  • Update packages/compass-import-export/src/import/import-types.ts

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • Update packages/compass-import-export/test/docs/all-bson-types.js

Co-authored-by: Rhys <Anemy@users.noreply.github.com>

  • rm comment
  • Symbol is deprecated.
  • add comment
  • relaxed: false so that we can support BSONSymbol
  • test exporting an empty collection
  • test exporting md5 fields
  • fill out missing tests
  • relaxed: false so that numbers can't lie
  • I guess the safest, most viable way to export binary data is to base64 encode it
  • debug
  • more specific error check
  • os-specific newlines in log files
  • fix screenshots for CSFLE tests

---------

Co-authored-by: Rhys <Anemy@users.noreply.github.com>
Branch: main
https://github.com/mongodb-js/compass/commit/f9860daa2dcaae9385f03c56030911f159d0c9fd

Generated at Wed Feb 07 22:43:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.